All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel@lists.xenproject.org
Cc: Wei.Liu2@citrix.com, ian.campbell@citrix.com,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
	stefano.stabellini@citrix.com, Jan Beulich <jbeulich@suse.com>,
	Keir Fraser <keir@xen.org>
Subject: Re: [RFC 1/2] xen/mm: Clarify the granularity for each Frame Number
Date: Wed, 5 Aug 2015 13:36:31 +0100	[thread overview]
Message-ID: <55C2034F.9070508@citrix.com> (raw)
In-Reply-To: <55C1F617.8090208@citrix.com>

On 05/08/15 12:40, Andrew Cooper wrote:
> I think a section about granularity is worthwhile, but probably a
> separate paragraph.  I think it is also worth keeping Xen's idea of
> memory all at 4K, and in cases where 64K is in use, require appropriate
> alignment in the parameter.

Which would confuse the reader because PFN which, based on the
description, is the OS Frame Number. This frame will always be in the
granularity of the OS.

So we need to introduce the concept of in each definition. This patch
makes clear that MFN and GFN is always 4KB and PFN may vary.

Regards,

-- 
Julien Grall

  parent reply	other threads:[~2015-08-05 12:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 11:28 [RFC 0/2] xen: Clarify the page granularity for the hypercall Julien Grall
2015-08-05 11:28 ` [RFC 1/2] xen/mm: Clarify the granularity for each Frame Number Julien Grall
2015-08-05 11:40   ` Andrew Cooper
2015-08-05 11:51     ` Ian Campbell
2015-08-05 12:36     ` Julien Grall [this message]
2015-08-05 12:46       ` Andrew Cooper
2015-08-05 13:18         ` Julien Grall
2015-08-12  7:16           ` Jan Beulich
2015-08-12  9:57             ` Julien Grall
2015-08-12 10:33               ` Jan Beulich
2015-08-12 11:13                 ` Julien Grall
2015-08-12 11:58                   ` Jan Beulich
2015-08-12 12:57                     ` Julien Grall
2015-08-12 13:25                       ` Jan Beulich
2015-08-05 11:28 ` [RFC 2/2] xen/public: grant-table: Specificy the size of the grant Julien Grall
2015-08-05 16:51   ` Stefano Stabellini
2015-08-12  7:21   ` Jan Beulich
2015-08-12 10:00     ` Julien Grall
2015-08-12 10:35       ` Jan Beulich
2015-08-12 11:08         ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C2034F.9070508@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=Wei.Liu2@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.