Re: [PATCH] r8169:Fill with zero Tx descriptors

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 8/5/2015 1:46 PM, Corcodel Marian wrote:

>   This patch fill with zero Tx descriptors before use.Is only
>   on    part by more patches but is critical.(critical)


> Signed-off-by: Corcodel Marian <corcodel.marian@gmail.com>

> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 3df51fa..bf78f94 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -7589,7 +7589,7 @@ static int rtl_open(struct net_device *dev)
>   	 * Rx and Tx descriptors needs 256 bytes alignment.
>   	 * dma_alloc_coherent provides more.
>   	 */
> -	tp->TxDescArray = dma_alloc_coherent(&pdev->dev, R8169_TX_RING_BYTES,
> +	tp->TxDescArray = dma_zalloc_coherent(&pdev->dev, R8169_TX_RING_BYTES,
>   					     &tp->TxPhyAddr, GFP_KERNEL);

    Please re-align the continuation line.

[...]

MBR, Sergei