From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH 2/7] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe Date: Wed, 5 Aug 2015 19:42:24 +0530 Message-ID: <55C219C8.8010304@ti.com> References: <1438701646-7876-1-git-send-email-kishon@ti.com> <1438701646-7876-3-git-send-email-kishon@ti.com> <20150804160631.GH23659@saruman.tx.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150804160631.GH23659-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: balbi-l0cyMroinI0@public.gmane.org Cc: rogerq-l0cyMroinI0@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, t-kristo-l0cyMroinI0@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org List-Id: linux-omap@vger.kernel.org Hi, On Tuesday 04 August 2015 09:36 PM, Felipe Balbi wrote: > On Tue, Aug 04, 2015 at 08:50:41PM +0530, Kishon Vijay Abraham I wrote: >> No functional change. Previously omap_control_phy_power() was used to power > > there is a slight functional change. You moved PHY power off from before > to after pm_runtime_enable(), clk_prepare_enable() and creation of the > PHY device. That ought to have a slight impact on how the driver > behaves. okay. I'll modify the commit log. I think it won't impact the functionality as such since the ->init and ->power_on callbacks won't be invoked at that point. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753533AbbHEOMf (ORCPT ); Wed, 5 Aug 2015 10:12:35 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:48938 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753006AbbHEOMb (ORCPT ); Wed, 5 Aug 2015 10:12:31 -0400 Message-ID: <55C219C8.8010304@ti.com> Date: Wed, 5 Aug 2015 19:42:24 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: CC: , , , , , , , Subject: Re: [PATCH 2/7] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe References: <1438701646-7876-1-git-send-email-kishon@ti.com> <1438701646-7876-3-git-send-email-kishon@ti.com> <20150804160631.GH23659@saruman.tx.rr.com> In-Reply-To: <20150804160631.GH23659@saruman.tx.rr.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday 04 August 2015 09:36 PM, Felipe Balbi wrote: > On Tue, Aug 04, 2015 at 08:50:41PM +0530, Kishon Vijay Abraham I wrote: >> No functional change. Previously omap_control_phy_power() was used to power > > there is a slight functional change. You moved PHY power off from before > to after pm_runtime_enable(), clk_prepare_enable() and creation of the > PHY device. That ought to have a slight impact on how the driver > behaves. okay. I'll modify the commit log. I think it won't impact the functionality as such since the ->init and ->power_on callbacks won't be invoked at that point. Thanks Kishon