From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by kanga.kvack.org (Postfix) with ESMTP id 45D886B0038 for ; Wed, 5 Aug 2015 10:50:43 -0400 (EDT) Received: by pabyb7 with SMTP id yb7so6036245pab.0 for ; Wed, 05 Aug 2015 07:50:43 -0700 (PDT) Received: from mga03.intel.com (mga03.intel.com. [134.134.136.65]) by mx.google.com with ESMTP id bg17si5660857pad.159.2015.08.05.07.50.40 for ; Wed, 05 Aug 2015 07:50:41 -0700 (PDT) Message-ID: <55C221EB.7060500@intel.com> Date: Wed, 05 Aug 2015 07:47:07 -0700 From: Dave Hansen MIME-Version: 1.0 Subject: Re: [PATCH] mm: add the block to the tail of the list in expand() References: <55BB4027.7080200@huawei.com> <55BC0392.2070205@intel.com> <55BECC85.7050206@huawei.com> <55BEE99E.8090901@intel.com> <55C011A6.1090003@huawei.com> <55C0CBC3.2000602@intel.com> <55C1C132.2010805@huawei.com> In-Reply-To: <55C1C132.2010805@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Xishi Qiu Cc: Andrew Morton , Mel Gorman , Vlastimil Babka , Johannes Weiner , Michal Hocko , iamjoonsoo.kim@lge.com, alexander.h.duyck@redhat.com, sasha.levin@oracle.com, Linux MM , LKML On 08/05/2015 12:54 AM, Xishi Qiu wrote: > I add some debug code like this, but it doesn't trigger the dump_stack(). ... > + if (!list_empty(&area->free_list[migratetype])) { > + printk("expand(), the list is not empty\n"); > + dump_stack(); > + } > + That will probably not trigger unless you have allocations that are falling back and converting other pageblocks from other migratetypes. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752156AbbHEOvW (ORCPT ); Wed, 5 Aug 2015 10:51:22 -0400 Received: from mga09.intel.com ([134.134.136.24]:30242 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbbHEOvV (ORCPT ); Wed, 5 Aug 2015 10:51:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,617,1432623600"; d="scan'208";a="777377277" Message-ID: <55C221EB.7060500@intel.com> Date: Wed, 05 Aug 2015 07:47:07 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Xishi Qiu CC: Andrew Morton , Mel Gorman , Vlastimil Babka , Johannes Weiner , Michal Hocko , iamjoonsoo.kim@lge.com, alexander.h.duyck@redhat.com, sasha.levin@oracle.com, Linux MM , LKML Subject: Re: [PATCH] mm: add the block to the tail of the list in expand() References: <55BB4027.7080200@huawei.com> <55BC0392.2070205@intel.com> <55BECC85.7050206@huawei.com> <55BEE99E.8090901@intel.com> <55C011A6.1090003@huawei.com> <55C0CBC3.2000602@intel.com> <55C1C132.2010805@huawei.com> In-Reply-To: <55C1C132.2010805@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/2015 12:54 AM, Xishi Qiu wrote: > I add some debug code like this, but it doesn't trigger the dump_stack(). ... > + if (!list_empty(&area->free_list[migratetype])) { > + printk("expand(), the list is not empty\n"); > + dump_stack(); > + } > + That will probably not trigger unless you have allocations that are falling back and converting other pageblocks from other migratetypes.