Re: [meta-selinux][PATCH v1] libpam: use wildcard for version and cleanup

[Philip Tricca <flihp@twobit.us>]

Shrikant,

On 07/30/2015 02:31 AM, Shrikant Bobade wrote:
> This patch provides green build for core-image-selinux
> (meta-selinux:master & poky:master) against libpam upgrade from 1.1.6 to
> 1.2.1,
> image boots fine,but I am unable to login at target. I have prepared
> build for qemuarm, does anyone else facing similar issue? please advice.

I've reproduced this issue. Build works, we can drop the DESTDIR patch
now. But login fails with the latest version.

> Observed the login issue appears even with disabled selinux support
> (selinux=0).

On a vanilla core-image-minimal with this libpam version login works
fine. The SELinux images however, even with SELinux in permissive /
disabled, login fails. I guess this means there's something wrong with
the SELinux bits in the libpam package.

Philip

> On Thu, Jul 30, 2015 at 2:55 PM, Shrikant Bobade
> <bobadeshrikant@gmail.com <mailto:bobadeshrikant@gmail.com>> wrote:
> 
>     From: Shrikant Bobade <shrikant_bobade@mentor.com
>     <mailto:shrikant_bobade@mentor.com>>
> 
>     use wildcard for version: adopting libpam upgrade from 1.1.6 to 1.2.1,
>     cleanup older recipe and remove patch sepermit-add-DESTDIR-prefix.patch
>     since the changes already available with latest source.
> 
>     Signed-off-by: Shrikant Bobade <shrikant_bobade@mentor.com
>     <mailto:shrikant_bobade@mentor.com>>
>     ---
>      .../pam/libpam/sepermit-add-DESTDIR-prefix.patch   |   31
>     --------------------
>      recipes-extended/pam/libpam_%.bbappend             |    3 ++
>      recipes-extended/pam/libpam_1.1.6.bbappend         |   10 -------
>      3 files changed, 3 insertions(+), 41 deletions(-)
>      delete mode 100644
>     recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch
>      create mode 100644 recipes-extended/pam/libpam_%.bbappend
>      delete mode 100644 recipes-extended/pam/libpam_1.1.6.bbappend
> 
>     diff --git
>     a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch
>     b/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch
>     deleted file mode 100644
>     index d48d386..0000000
>     --- a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch
>     +++ /dev/null
>     @@ -1,31 +0,0 @@
>     -Subject: [PATCH] libpam: add missing DESTDIR prefix
>     -
>     -The DESTDIR prefix is missing, this will cause build failures for
>     -mkdir /var/run/sepermit on the host.
>     -
>     -| mkdir -p /var/run/sepermit
>     -| mkdir: cannot create directory `/var/run/sepermit': Permission denied
>     -
>     -Upstream-Status: Pending
>     -
>     -Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com
>     <mailto:Xin.Ouyang@windriver.com>>
>     ----
>     - modules/pam_sepermit/Makefile.am |    2 +-
>     - 1 files changed, 1 insertions(+), 1 deletions(-)
>     -
>     -diff --git a/modules/pam_sepermit/Makefile.am
>     b/modules/pam_sepermit/Makefile.am
>     -index cfc5594..bc82275 100644
>     ---- a/modules/pam_sepermit/Makefile.am
>     -+++ b/modules/pam_sepermit/Makefile.am
>     -@@ -35,7 +35,7 @@ if HAVE_LIBSELINUX
>     -   securelib_LTLIBRARIES = pam_sepermit.la <http://pam_sepermit.la>
>     -
>     - install-data-local:
>     --      mkdir -p $(sepermitlockdir)
>     -+      mkdir -p $(DESTDIR)$(sepermitlockdir)
>     - endif
>     - if ENABLE_REGENERATE_MAN
>     - noinst_DATA = README pam_sepermit.8 sepermit.conf.5
>     ---
>     -1.7.5.4
>     -
>     diff --git a/recipes-extended/pam/libpam_%.bbappend
>     b/recipes-extended/pam/libpam_%.bbappend
>     new file mode 100644
>     index 0000000..adcf938
>     --- /dev/null
>     +++ b/recipes-extended/pam/libpam_%.bbappend
>     @@ -0,0 +1,3 @@
>     +inherit enable-selinux
>     +
>     +RDEPENDS_${PN}-runtime += "${@target_selinux(d, 'pam-plugin-selinux')}"
>     diff --git a/recipes-extended/pam/libpam_1.1.6.bbappend
>     b/recipes-extended/pam/libpam_1.1.6.bbappend
>     deleted file mode 100644
>     index 71acecc..0000000
>     --- a/recipes-extended/pam/libpam_1.1.6.bbappend
>     +++ /dev/null
>     @@ -1,10 +0,0 @@
>     -#FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>     -FILESPATH_append := ":${@base_set_filespath(['${THISDIR}/${PN}'], d)}"
>     -
>     -SRC_URI += "file://sepermit-add-DESTDIR-prefix.patch"
>     -
>     -PR .= ".4"
>     -
>     -inherit enable-selinux
>     -
>     -RDEPENDS_${PN}-runtime += "${@target_selinux(d, 'pam-plugin-selinux')}"
>     --
>     1.7.9.5
> 
> 
> 
>