From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46498)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ZN0m4-0007T9-82
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 11:38:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ZN0ly-0003Q3-RT
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 11:38:35 -0400
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:44067)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ZN0ly-0003Pn-LL
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 11:38:30 -0400
Message-ID: <55C22DE7.2060204@weilnetz.de>
Date: Wed, 05 Aug 2015 17:38:15 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1438337876-13558-1-git-send-email-berrange@redhat.com>
	<55BB6EED.2010805@redhat.com> <55BBB755.1060503@weilnetz.de>
	<20150805095246.GB16246@redhat.com>
	<55C1ED97.2080005@weilnetz.de> <55C2064B.2050606@redhat.com>
In-Reply-To: <55C2064B.2050606@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] QEMU 2.4 for Windows - current status
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

Am 05.08.2015 um 14:49 schrieb Paolo Bonzini:
> On 05/08/2015 13:03, Stefan Weil wrote:
>> Fix sigsetjmp for w64
>> http://repo.or.cz/w/qemu/ar7.git/commit/8fa9c07c9a33174905e67589bea6be3e278712cb
> Does this work too?
>
> diff --git a/cpu-exec.c b/cpu-exec.c
> index 75694f3..d882b89 100644
> --- a/cpu-exec.c
> +++ b/cpu-exec.c
> @@ -17,6 +17,7 @@
>    * License along with this library; if not, see <http://www.gnu.org/licenses/>.
>    */
>   #include "config.h"
> +#include "qemu-common.h"
>   #include "cpu.h"
>   #include "trace.h"
>   #include "disas/disas.h"

No, that still gets the wrong definition for setjmp from
/usr/share/mingw-w64/include/setjmp.h.

For the future, I'd prefer a solution which restricts the special
handling of sigsetjmp to those locations where it is needed.
As far as I see, only cpu-exec.c uses sigsetjmp for returns
from generated code.

Maybe we can also add support for stack unwinding to the
generated code, so no special hack for w64 will be needed
anymore.

Stefan