Re: [rtc-linux] Re: [PATCH 08/11] rtc: m48t59: clean up m48t59_nvram_read()/m48t59_nvram_write()

[Vladimir Zapolskiy <vz@mleia.com>]

Hi Alexandre,

On 05.08.2015 11:27, Alexandre Belloni wrote:
> On 27/07/2015 at 00:48:33 +0300, Vladimir Zapolskiy wrote :
>> @@ -365,11 +366,10 @@ static ssize_t m48t59_nvram_write(struct file *filp, struct kobject *kobj,
>>  	ssize_t cnt = 0;
>>  	unsigned long flags;
>>  
>> -	for (; size > 0 && pos < pdata->offset; cnt++, size--) {
>> -		spin_lock_irqsave(&m48t59->lock, flags);
>> +	spin_lock_irqsave(&m48t59->lock, flags);
>> +
>> +	for (; cnt < size; cnt++)
>>  		M48T59_WRITE(*buf++, cnt);
>> -		spin_unlock_irqrestore(&m48t59->lock, flags);
>> -	}
>>  
> 
> Isn't a spin_unlock_irqrestore() missing?
> 

oops, you are correct, will update this change.

With best wishes,
Vladimir

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.