From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40497)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ZN5KV-0000By-Qd
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 16:30:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ZN5KR-0002Fl-O9
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 16:30:27 -0400
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:47381)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ZN5KR-0002Fh-II
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 16:30:23 -0400
Message-ID: <55C27257.1010806@weilnetz.de>
Date: Wed, 05 Aug 2015 22:30:15 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1438337876-13558-1-git-send-email-berrange@redhat.com>
	<55BB6EED.2010805@redhat.com> <55BBB755.1060503@weilnetz.de>
	<20150805095246.GB16246@redhat.com> <55C1ED97.2080005@weilnetz.de>
	<E0CEE935-6984-4758-9DBE-BB1737CAD6D6@livius.net>
	<55C2405B.4050008@redhat.com>
	<6E1223CD-97D8-4675-AAFE-DF2F8298C8E1@livius.net>
In-Reply-To: <6E1223CD-97D8-4675-AAFE-DF2F8298C8E1@livius.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] QEMU 2.4 for Windows - current status
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liviu Ionescu <ilg@livius.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developer <qemu-devel@nongnu.org>

Am 05.08.2015 um 20:39 schrieb Liviu Ionescu:
>> On 05 Aug 2015, at 19:56, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> ... I am not sure why things break for Stefan...
> I confirm Stefan's conclusion, neither in my configuration adding
>
> #include "qemu-common.h"
>
> ... in cpu-exec.c makes any difference.
>
> however adding:
>
> #if defined(_WIN64)
> #ifdef sigsetjmp
> #undef sigsetjmp
> #endif
> #define sigsetjmp(env, savesigs) _setjmp(env, NULL)
> #endif
>
> ... fixes the problem, my custom QEMU happily blinks the LEDs on Win 8.1 64-bits (see below).
>
> perhaps a headers check would be helpful, such mysterious behaviours usually back fire at a certain point.
>
>
> regards,
>
> Liviu

http://qemu.weilnetz.de/test/cpu-exec.i shows the result of
the C preprocessor:

cpu-exec.c gets QEMU's os-win32.h with our definition of setjmp
early, but the system header file setjmp.h is included later, and
that file re-defines our definitions. Including setjmp.h from
os-win32.h would solve the problem, but I think there is a
better solution.

I am planning to remove the special definitions for _WIN64 from
os-win32.h and add them to cpu-exec.c, similar to the code
above (which can be shortened a little)
but with some comment lines added.

As I already said, this modification is needed for all versions
of QEMU, and it will stay unfixed in 2.4.0 which is nearly finished.

Regards
Stefan