From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 0D858E00A54; Wed, 5 Aug 2015 13:32:51 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 SPF_HELO_PASS SPF: HELO matches SPF record * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from ptmx.org (ptmx.org [178.63.28.110]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 5466DE009B3 for ; Wed, 5 Aug 2015 13:32:47 -0700 (PDT) Received: from [192.168.178.14] (chello062178118086.5.14.vie.surfer.at [62.178.118.86]) by ptmx.org (Postfix) with ESMTPSA id B54E537451; Wed, 5 Aug 2015 22:32:30 +0200 (CEST) Message-ID: <55C272EE.6040908@pseudoterminal.org> Date: Wed, 05 Aug 2015 22:32:46 +0200 From: Carlos Rafael Giani User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yuqing Zhu , meta-freescale@yoctoproject.org References: <1438282514-12741-1-git-send-email-b54851@freescale.com> <1438282514-12741-2-git-send-email-b54851@freescale.com> In-Reply-To: <1438282514-12741-2-git-send-email-b54851@freescale.com> Subject: Re: [meta-fsl-arm][PATCH v4 1/4] gstreamer1.0-plugins-base: Add gstplaybin related patch X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2015 20:32:51 -0000 Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit This patch looks generally OK to me. The pango packageconfig could probably even be added to the gstreamer1.0-plugins-base.inc file in OE-core, since pango is present in OE-core. In fact, I don't know why it isn't already included in the default packageconfig of gstreamer1.0-plugins-base. But why do you view pango as mx6/mx7 specific? Am 2015-07-30 um 20:55 schrieb Yuqing Zhu: > -Remove default deinterlace flag in playbin for i.MX s/5/6/7 SoCs. > > -Remove native video flag in playbin for i.MX s/5/6/7 SoCs because it will cause subtitle error. > > -Enable pango plugin to generate texture of the video movie. > It is the specific feature for i.MX 6/7 SoCs. > > Signed-off-by: Yuqing Zhu > --- > ...deo.patch => gstplaybin-remove-flag-deinterlace.patch} | 10 +++++----- > .../gstreamer/gstreamer1.0-plugins-base_%.bbappend | 15 +++++++++++---- > 2 files changed, 16 insertions(+), 9 deletions(-) > rename recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/{gstplaybin-enable-native-video.patch => gstplaybin-remove-flag-deinterlace.patch} (79%) > > diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-remove-flag-deinterlace.patch > similarity index 79% > rename from recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch > rename to recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-remove-flag-deinterlace.patch > index 15322bd..f237776 100644 > --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch > +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-remove-flag-deinterlace.patch > @@ -1,11 +1,11 @@ > From 9cfb86cd100904f0ef2626f348695bd2d3416c6a Mon Sep 17 00:00:00 2001 > From: Jian Li > Date: Mon, 23 Jun 2014 14:14:07 +0800 > -Subject: [PATCH] gstplaybin enable native video > +Subject: [PATCH] gstplaybin remove default deinterlace flag > > -- use native video patch in playbin for i.MX SoCs > +- remove default deinterlace flag in playbin for i.MX SoCs > > -Upstream Status: Inappropriate [platform specific] > +Upstream-Status: Inappropriate [platform specific] > > Signed-off-by: Jian Li > --- > @@ -22,10 +22,10 @@ index fc02ca3..c342438 100644 > #define DEFAULT_FLAGS GST_PLAY_FLAG_AUDIO | GST_PLAY_FLAG_VIDEO | GST_PLAY_FLAG_TEXT | \ > - GST_PLAY_FLAG_SOFT_VOLUME | GST_PLAY_FLAG_DEINTERLACE | \ > - GST_PLAY_FLAG_SOFT_COLORBALANCE > -+ GST_PLAY_FLAG_SOFT_VOLUME | GST_PLAY_FLAG_NATIVE_VIDEO > ++ GST_PLAY_FLAG_SOFT_VOLUME > #define DEFAULT_N_VIDEO 0 > #define DEFAULT_CURRENT_VIDEO -1 > #define DEFAULT_N_AUDIO 0 > --- > +-- > 1.7.9.5 > > diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend > index 5b939d4..e7e148e 100644 > --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend > +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend > @@ -1,9 +1,16 @@ > - > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > > -SRC_URI_append_mxs = " file://gstplaybin-enable-native-video.patch" > -SRC_URI_append_mx5 = " file://gstplaybin-enable-native-video.patch" > -SRC_URI_append_mx6 = " file://gstplaybin-enable-native-video.patch" > +SRC_URI_append_mxs = " file://gstplaybin-remove-flag-deinterlace.patch" > +SRC_URI_append_mx5 = " file://gstplaybin-remove-flag-deinterlace.patch" > +IMX_PATCHES = " file://gstplaybin-remove-flag-deinterlace.patch" > + > + > +SRC_URI_append_mx6 = "${IMX_PATCHES}" > +SRC_URI_append_mx7 = "${IMX_PATCHES}" > + > +# Enable pango lib for i.MX 6/7 SoCs > +PACKAGECONFIG_append_mx6 = " pango " > +PACKAGECONFIG_append_mx7 = " pango " > > PACKAGE_ARCH_mxs = "${MACHINE_SOCARCH}" > PACKAGE_ARCH_mx5 = "${MACHINE_SOCARCH}"