From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 06 Aug 2015 05:16:01 +0200 (CEST) Received: from irl-smtp01.263.net ([54.76.167.174]:39659 "EHLO irl-smtp01.263.net" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006810AbbHFDP6ibRYs (ORCPT ); Thu, 6 Aug 2015 05:15:58 +0200 Received: from [172.16.12.109] (localhost.localdomain [127.0.0.1]) by irl-smtp01.263.net (Postfix) with ESMTP id A788D7F8B9; Thu, 6 Aug 2015 11:14:08 +0800 (CST) X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: cpgs@samsung.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <96e885a40f323c1babc89f48466bf4e5> X-ATTACHMENT-NUM: 0 X-SENDER: lintao@rock-chips.com X-DNS-TYPE: 0 Received: from [172.16.12.109] (unknown [58.22.7.114]) by irl-smtp01.263.net (Postfix) whith ESMTP id 24785ESHPLP; Thu, 06 Aug 2015 11:14:07 +0800 (CST) Subject: Re: [RFC PATCH v3 2/5] Documentation: synopsys-dw-mshc: add bindings for idmac and edmac To: Jaehoon Chung , Doug Anderson References: <1438762614-22154-1-git-send-email-shawn.lin@rock-chips.com> <1438762672-22243-1-git-send-email-shawn.lin@rock-chips.com> <55C2C453.3000005@samsung.com> Cc: shawn.lin@rock-chips.com, Ulf Hansson , Seungwon Jeon , linux-mips@linux-mips.org, Arnd Bergmann , Alexandre Belloni , Alexey Brodkin , Stefan Agner , Zhou Wang , Kumar Gala , Alim Akhtar , Ian Campbell , Wang Long , Rob Herring , Chaotian Jing , Lukasz Majewski , Jun Nie , Catalin Marinas , Kevin Hao , Olof Johansson , Ray Jui , Govindraj Raja , linux-samsung-soc , Heiko Stuebner , "Rafael J. Wysocki" , Geert Uytterhoeven , Vineet Gupta , Scott Branden , Anand Moon , "open list:ARM/Rockchip SoC..." , Krzysztof Kozlowski , Tushar Behera , Pawel Moll , Will Deacon , Mischa Jonker , Ralf Baechle , Vincent Yang , Stephen Warren , "devicetree@vger.kernel.org" , Kukjin Kim , Tomeu Vizoso , Stephen Boyd , Russell King , Joachim Eastwood , Sjoerd Simons , Weijun Yang , Peter Griffin , "linux-arm-kernel@lists.infradead.org" , addy ke , Uwe Kleine-K?nig , Kevin Hilman , Andrew Bresticker , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Zhangfei Gao , Wei Xu , Andreas Faerber , Mark Rutland , Srinivas Kandagatla , CPGS From: Shawn Lin Message-ID: <55C2D0F3.8000300@rock-chips.com> Date: Thu, 6 Aug 2015 11:13:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55C2C453.3000005@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 48649 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: shawn.lin@rock-chips.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips 在 2015/8/6 10:20, Jaehoon Chung 写道: > On 08/06/2015 11:16 AM, Doug Anderson wrote: >> Shawn, >> >> On Wed, Aug 5, 2015 at 1:17 AM, Shawn Lin wrote: >>> synopsys-dw-mshc supports three types of transfer mode. We add bindings >>> and description for how to use them at runtime. Without idmac and edmac >>> property, pio is the default transfer mode. Make sure that Idmac and emdac >>> should not be used simultaneously. >> Can't you just read the HCON register? >> >> [17:16]: DMA_INTERFACE >> 00: none >> 01: DW_DMA >> 10: GENERIC_DMA >> 11: NON-DW-DMA > If read it and get the exactly information. I think we can use that information. It's helpful really, but the description is ambiguous. ：( So I make a big big mistake when I read it for the firest time . I was just wondering the "mismatch" value from HCON and my databook. Here I get details from our ASIC team guy : // Name: DMA_INTERFACE // Default: None // Values: None (0), DW-DMA (1), Generic-DMA (2), NON-DW-DMA (3) // Enabled: INTERNAL_DMAC==0 // // Configures the type for DMA interface. In addition to AMBA host interface, // the data FIFO can be accesses by the optional DMA interface. The DMA type // could be either DW-DMA, which provides hand shake signals to DW_ahb_dmac // controller, or a generic DMA interface which provides a simpler // request/acknowledgement protocol and dedicated DMA data-bus, or // no DMA interface. `define DMA_INTERFACE 1 if we use idmac, DMA_INTERFACE should be "0", and we get 2b'00 from HCON[17:16] if we use edmac, DMA_INTERFACE should be "1", "2" and we get 2b'01 ,2b'10 from HCON[17:16] respectively . But if only support PIO mode, DMA_INTERFACE should be "3", and we get 2b'11 from HCON[17:16]. So, "none" means IDMAC, "DW_DMA"/"GENERIC_DMA" refer to two types of external dma and "NON-DW-DMA" means pio from databook . It's a little difficult to understand it. This makes my work easy! Thanks, Doug and Jeahoon. > Best Regards, > Jaehoon Chung > > > > -- Shawn Lin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Subject: Re: [RFC PATCH v3 2/5] Documentation: synopsys-dw-mshc: add bindings for idmac and edmac Date: Thu, 6 Aug 2015 11:13:55 +0800 Message-ID: <55C2D0F3.8000300@rock-chips.com> References: <1438762614-22154-1-git-send-email-shawn.lin@rock-chips.com> <1438762672-22243-1-git-send-email-shawn.lin@rock-chips.com> <55C2C453.3000005@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <55C2C453.3000005@samsung.com> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Jaehoon Chung , Doug Anderson Cc: shawn.lin@rock-chips.com, Ulf Hansson , Seungwon Jeon , linux-mips@linux-mips.org, Arnd Bergmann , Alexandre Belloni , Alexey Brodkin , Stefan Agner , Zhou Wang , Kumar Gala , Alim Akhtar , Ian Campbell , Wang Long , Rob Herring , Chaotian Jing , Lukasz Majewski , Jun Nie , Catalin Marinas , Kevin Hao , Olof Johansson , Ray Jui List-Id: linux-mmc@vger.kernel.org =E5=9C=A8 2015/8/6 10:20, Jaehoon Chung =E5=86=99=E9=81=93: > On 08/06/2015 11:16 AM, Doug Anderson wrote: >> Shawn, >> >> On Wed, Aug 5, 2015 at 1:17 AM, Shawn Lin = wrote: >>> synopsys-dw-mshc supports three types of transfer mode. We add bind= ings >>> and description for how to use them at runtime. Without idmac and e= dmac >>> property, pio is the default transfer mode. Make sure that Idmac an= d emdac >>> should not be used simultaneously. >> Can't you just read the HCON register? >> >> [17:16]: DMA_INTERFACE >> 00: none >> 01: DW_DMA >> 10: GENERIC_DMA >> 11: NON-DW-DMA > If read it and get the exactly information. I think we can use that i= nformation. It's helpful really, but the description is ambiguous. =EF=BC=9A( So I make a big big mistake when I read it for the firest time . I was just wondering the "mismatch" value from HCON and my databook. Here I get details from our ASIC team guy : // Name: DMA_INTERFACE // Default: None // Values: None (0), DW-DMA (1), Generic-DMA (2), NON-DW-DMA (3) // Enabled: INTERNAL_DMAC=3D=3D0 // // Configures the type for DMA interface. In addition to AMBA host=20 interface, // the data FIFO can be accesses by the optional DMA interface. The DM= A=20 type // could be either DW-DMA, which provides hand shake signals to=20 DW_ahb_dmac // controller, or a generic DMA interface which provides a simpler // request/acknowledgement protocol and dedicated DMA data-bus, or // no DMA interface. `define DMA_INTERFACE 1 if we use idmac, DMA_INTERFACE should be "0", and we get 2b'00 from=20 HCON[17:16] if we use edmac, DMA_INTERFACE should be "1", "2" and we get 2b'01 ,= 2b'10 from HCON[17:16] respectively . But if only support PIO mode, DMA_INTERFACE should be "3", and we=20 get 2b'11 from HCON[17:16]. So, "none" means IDMAC, "DW_DMA"/"GENERIC_DMA" refer to two types of= =20 external dma and "NON-DW-DMA" means pio from databook . It's a little=20 difficult to understand it. This makes my work easy! Thanks, Doug and Jeahoon. > Best Regards, > Jaehoon Chung > > > > --=20 Shawn Lin