From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNFVH-0001qt-2J for qemu-devel@nongnu.org; Thu, 06 Aug 2015 03:22:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNFVD-00067f-S0 for qemu-devel@nongnu.org; Thu, 06 Aug 2015 03:22:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNFVD-00066s-MR for qemu-devel@nongnu.org; Thu, 06 Aug 2015 03:22:11 -0400 Message-ID: <55C30B1B.3000202@redhat.com> Date: Thu, 06 Aug 2015 15:22:03 +0800 From: Jason Wang MIME-Version: 1.0 References: <1438677044-13030-1-git-send-email-yanghy@cn.fujitsu.com> <1438677044-13030-11-git-send-email-yanghy@cn.fujitsu.com> In-Reply-To: <1438677044-13030-11-git-send-email-yanghy@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 10/11] filter/buffer: update command description and help List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: thuth@redhat.com, zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, eddie.dong@intel.com, Markus Armbruster , mrhines@linux.vnet.ibm.com, Luiz Capitulino , stefanha@redhat.com On 08/04/2015 04:30 PM, Yang Hongyang wrote: > now that we have a buffer netfilter, update the command > description and help. > > Signed-off-by: Yang Hongyang > CC: Luiz Capitulino > CC: Markus Armbruster > --- > hmp-commands.hx | 2 +- > qemu-options.hx | 5 ++++- > qmp-commands.hx | 2 +- > 3 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 902e2d1..63177a8 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -1255,7 +1255,7 @@ ETEXI > { > .name = "netfilter_add", > .args_type = "netfilter:O", > - .params = "[type],id=str,netdev=str[,chain=in|out|all,prop=value][,...]", > + .params = "[buffer],id=str,netdev=str[,chain=in|out|all,prop=value][,...]", Looks like chain is mandatory in patch 2. > .help = "add netfilter", > .mhandler.cmd = hmp_netfilter_add, > .command_completion = netfilter_add_completion, > diff --git a/qemu-options.hx b/qemu-options.hx > index 0d52d02..eeaf2a1 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -1575,7 +1575,10 @@ DEF("net", HAS_ARG, QEMU_OPTION_net, > "socket][,vlan=n][,option][,option][,...]\n" > " old way to initialize a host network interface\n" > " (use the -netdev option if possible instead)\n", QEMU_ARCH_ALL) > -DEF("netfilter", HAS_ARG, QEMU_OPTION_netfilter, "", QEMU_ARCH_ALL) > +DEF("netfilter", HAS_ARG, QEMU_OPTION_netfilter, > + "-netfilter buffer,id=str,netdev=str[,chain=in|out|all,interval=n]\n" > + " buffer netdev in/out packets. if interval provided, will release\n" > + " packets by interval. interval scale: microsecond\n", QEMU_ARCH_ALL) > STEXI > @item -net nic[,vlan=@var{n}][,macaddr=@var{mac}][,model=@var{type}] [,name=@var{name}][,addr=@var{addr}][,vectors=@var{v}] > @findex -net > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 4f0dc98..9419a6f 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -947,7 +947,7 @@ Arguments: > Example: > > -> { "execute": "netfilter_add", > - "arguments": { "type": "type", "id": "nf0", > + "arguments": { "type": "buffer", "id": "nf0", > "netdev": "bn", > "chain": "in" } } > <- { "return": {} }