From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49138)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZNFlk-0006DT-1i
	for qemu-devel@nongnu.org; Thu, 06 Aug 2015 03:39:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZNFlf-0006Wq-Dj
	for qemu-devel@nongnu.org; Thu, 06 Aug 2015 03:39:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35137)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZNFlf-0006Wc-82
	for qemu-devel@nongnu.org; Thu, 06 Aug 2015 03:39:11 -0400
Message-ID: <55C30F17.3070809@redhat.com>
Date: Thu, 06 Aug 2015 15:39:03 +0800
From: Jason Wang <jasowang@redhat.com>
MIME-Version: 1.0
References: <1438677044-13030-1-git-send-email-yanghy@cn.fujitsu.com>	<1438677044-13030-11-git-send-email-yanghy@cn.fujitsu.com>	<55C30B1B.3000202@redhat.com>
	<55C30D48.3060109@cn.fujitsu.com>
In-Reply-To: <55C30D48.3060109@cn.fujitsu.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 10/11] filter/buffer: update command
 description and help
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yang Hongyang <yanghy@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: thuth@redhat.com, zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, eddie.dong@intel.com, Markus Armbruster <armbru@redhat.com>, mrhines@linux.vnet.ibm.com, Luiz Capitulino <lcapitulino@redhat.com>, stefanha@redhat.com



On 08/06/2015 03:31 PM, Yang Hongyang wrote:
>
>
> On 08/06/2015 03:22 PM, Jason Wang wrote:
>>
>>
>> On 08/04/2015 04:30 PM, Yang Hongyang wrote:
>>> now that we have a buffer netfilter, update the command
>>> description and help.
>>>
>>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>>> CC: Luiz Capitulino <lcapitulino@redhat.com>
>>> CC: Markus Armbruster <armbru@redhat.com>
>>> ---
>>>   hmp-commands.hx | 2 +-
>>>   qemu-options.hx | 5 ++++-
>>>   qmp-commands.hx | 2 +-
>>>   3 files changed, 6 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>>> index 902e2d1..63177a8 100644
>>> --- a/hmp-commands.hx
>>> +++ b/hmp-commands.hx
>>> @@ -1255,7 +1255,7 @@ ETEXI
>>>       {
>>>           .name       = "netfilter_add",
>>>           .args_type  = "netfilter:O",
>>> -        .params     =
>>> "[type],id=str,netdev=str[,chain=in|out|all,prop=value][,...]",
>>> +        .params     =
>>> "[buffer],id=str,netdev=str[,chain=in|out|all,prop=value][,...]",
>>
>> Looks like chain is mandatory in patch 2.
>
> It is optional, default is "all". 

Right, I see.