All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: Chen Bough <Haibo.Chen@freescale.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks]
Date: Thu, 6 Aug 2015 11:06:45 +0200	[thread overview]
Message-ID: <55C323A5.6050303@suse.cz> (raw)
In-Reply-To: <BY1PR03MB13889A6C31FC542DB544CE479A740@BY1PR03MB1388.namprd03.prod.outlook.com>

On 08/06/2015, 09:42 AM, Chen Bough wrote:
> I read your attached log and patch, yes, dma memory leak will happen when
> more than one pre_request execute. The method of ++next->cookie is not good,
> your patch seems good, but I still need some time to test the patch, because
> you unmap the dma in sdhci_finish_data rather than the sdhci_post_req.

Hi,

yes, this is not correct. We can perhaps differentiate according to the
COOKIE value. Should I fix it or are you going to prepare a patch based
on my RFC?

thanks,
-- 
js
suse labs

  reply	other threads:[~2015-08-06  9:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30  9:31 [SHDCI] Heavy (thousands) DMA leaks Jiri Slaby
2015-07-31  6:56 ` Chen Bough
2015-08-03  9:30 ` Chen Bough
2015-08-03  9:39   ` Jiri Slaby
2015-08-05 11:52     ` Jiri Slaby
2015-08-05 15:11       ` [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks] Jiri Slaby
2015-08-05 16:25         ` Pavel Machek
2015-08-06  7:42         ` Chen Bough
2015-08-06  7:42           ` Chen Bough
2015-08-06  9:06           ` Jiri Slaby [this message]
2015-08-06  9:17             ` Chen Bough
2015-08-06  9:17               ` Chen Bough
2015-08-24 16:26               ` Laura Abbott
2015-08-25  1:50                 ` Chen Bough
2015-08-25  1:50                   ` Chen Bough

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C323A5.6050303@suse.cz \
    --to=jslaby@suse.cz \
    --cc=Haibo.Chen@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.