From: Guenter Roeck <linux@roeck-us.net>
To: Barry Song <21cnbao@gmail.com>,
wim@iguana.be, linux-watchdog@vger.kernel.org
Cc: workgroup.linux@csr.com, William Wang <William.Wang@csr.com>,
Guo Zeng <guo.zeng@csr.com>, Barry Song <Baohua.Song@csr.com>
Subject: Re: [PATCH] watchdog : sirf: add support for CSR atlas7 SoC
Date: Thu, 06 Aug 2015 02:24:05 -0700 [thread overview]
Message-ID: <55C327B5.4050902@roeck-us.net> (raw)
In-Reply-To: <1438849919-27724-1-git-send-email-21cnbao@gmail.com>
On 08/06/2015 01:31 AM, Barry Song wrote:
> From: William Wang <William.Wang@csr.com>
>
> This patch adds support for the new CSR atlas7 chips. prima2 and atlas7
> are similar in chip design, but the register layout and flows have some
> differences.
>
> This patch puts the differences including register layout and operations
> in dt private data, so that one driver can be compatible for two chips.
>
> Signed-off-by: William Wang <William.Wang@csr.com>
> Signed-off-by: Guo Zeng <guo.zeng@csr.com>
> Signed-off-by: Barry Song <Baohua.Song@csr.com>
You are pretty much doubling the size of this driver (from 225 to 446 LOC).
I don't see the benefits of having a single driver, sorry. It just makes
it very difficult to maintain. Please make this a separate driver.
Thanks,
Guenter
next prev parent reply other threads:[~2015-08-06 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 8:31 [PATCH] watchdog : sirf: add support for CSR atlas7 SoC Barry Song
2015-08-06 9:24 ` Guenter Roeck [this message]
2015-08-10 2:30 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C327B5.4050902@roeck-us.net \
--to=linux@roeck-us.net \
--cc=21cnbao@gmail.com \
--cc=Baohua.Song@csr.com \
--cc=William.Wang@csr.com \
--cc=guo.zeng@csr.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.