Re: [PATCH v2 4/4] i2c: arb-gpio-challenge: use of_get_i2c_adapter_by_node interface

[Vladimir Zapolskiy <vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>]

Hi Wolfram,

On 06.08.2015 03:51, Wolfram Sang wrote:
> On Mon, Jul 27, 2015 at 05:30:51PM +0300, Vladimir Zapolskiy wrote:
>> This change is needed to properly lock I2C parent bus driver.
>>
>> Prior to this change i2c_put_adapter() is misused, which may lead
>> to an overflow over zero of I2C bus driver user counter.
>>
>> By the way added a missing of_node_put() to eliminate memory leak,
>> if OF_DYNAMIC is enabled.
>>
>> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
>> Cc: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> 
> Applied to for-next! However...

great, thank you.

>> +	of_node_put(parent_np);
> 
> I removed this line. Please resend this as a seperate patch since it
> fixes a seperate issue.
> 

Definitely, I always forget about non-zero probability of any commit
reverse. I'll resend this change plus at least two more similar fixes in
drivers/i2c I have in mind in a separate series.

--
With best wishes,
Vladimir