From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Date: Thu, 06 Aug 2015 11:17:36 +0000 Subject: Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies Message-Id: <55C34250.3040801@citrix.com> List-Id: References: <1438711972-18752-1-git-send-email-julien.grall@citrix.com> <1438711972-18752-5-git-send-email-julien.grall@citrix.com> <55C33E4E.4050704@citrix.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 06/08/15 12:06, Stefano Stabellini wrote: > On Thu, 6 Aug 2015, Julien Grall wrote: >> Hi, >> >> >> On 04/08/15 19:12, Julien Grall wrote: >>> diff --git a/include/xen/page.h b/include/xen/page.h >>> index c5ed20b..e7e1425 100644 >>> --- a/include/xen/page.h >>> +++ b/include/xen/page.h >>> @@ -3,9 +3,9 @@ >>> >>> #include >>> >>> -static inline unsigned long page_to_mfn(struct page *page) >>> +static inline unsigned long page_to_gfn(struct page *page) >>> { >>> - return pfn_to_mfn(page_to_pfn(page)); >>> + return pfn_to_gfn(page_to_pfn(page)); >>> } >> >> I've just noticed that there is a function gfn_to_page used for KVM. >> >> Maybe I should rename page_to_gfn to xen_page_to_gfn to avoid confusion >> with KVM one? > > Yeah, prepending xen would help to avoid namespace pollution. Will do. May I keep your Reviewed-by for this mechanical change? Regards, -- Julien Grall From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies Date: Thu, 6 Aug 2015 12:17:36 +0100 Message-ID: <55C34250.3040801@citrix.com> References: <1438711972-18752-1-git-send-email-julien.grall@citrix.com> <1438711972-18752-5-git-send-email-julien.grall@citrix.com> <55C33E4E.4050704@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp02.citrix.com ([66.165.176.63]:3899 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755406AbbHFLSd (ORCPT ); Thu, 6 Aug 2015 07:18:33 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Stefano Stabellini Cc: linux-fbdev@vger.kernel.org, "H. Peter Anvin" , Jiri Slaby , Boris Ostrovsky , Russell King , linux-scsi@vger.kernel.org, Tomi Valkeinen , x86@kernel.org, Ingo Molnar , linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, Jean-Christophe Plagniol-Villard , ian.campbell@citrix.com, "James E.J. Bottomley" , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Juergen Gross , Wei Liu , Greg Kroah-Hartman , Dmitry Torokhov , linux-kernel@vger.kernel.org, David Vrabel , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, =?windo On 06/08/15 12:06, Stefano Stabellini wrote: > On Thu, 6 Aug 2015, Julien Grall wrote: >> Hi, >> >> >> On 04/08/15 19:12, Julien Grall wrote: >>> diff --git a/include/xen/page.h b/include/xen/page.h >>> index c5ed20b..e7e1425 100644 >>> --- a/include/xen/page.h >>> +++ b/include/xen/page.h >>> @@ -3,9 +3,9 @@ >>> >>> #include >>> >>> -static inline unsigned long page_to_mfn(struct page *page) >>> +static inline unsigned long page_to_gfn(struct page *page) >>> { >>> - return pfn_to_mfn(page_to_pfn(page)); >>> + return pfn_to_gfn(page_to_pfn(page)); >>> } >> >> I've just noticed that there is a function gfn_to_page used for KVM. >> >> Maybe I should rename page_to_gfn to xen_page_to_gfn to avoid confusion >> with KVM one? > > Yeah, prepending xen would help to avoid namespace pollution. Will do. May I keep your Reviewed-by for this mechanical change? Regards, -- Julien Grall From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from SMTP02.CITRIX.COM (smtp02.citrix.com [66.165.176.63]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 0CDF51A0023 for ; Thu, 6 Aug 2015 21:18:35 +1000 (AEST) Message-ID: <55C34250.3040801@citrix.com> Date: Thu, 6 Aug 2015 12:17:36 +0100 From: Julien Grall MIME-Version: 1.0 To: Stefano Stabellini CC: , "H. Peter Anvin" , "Jiri Slaby" , Boris Ostrovsky , Russell King , , "Tomi Valkeinen" , , Ingo Molnar , , , Jean-Christophe Plagniol-Villard , , "James E.J. Bottomley" , Thomas Gleixner , , Juergen Gross , "Wei Liu" , Greg Kroah-Hartman , Dmitry Torokhov , , David Vrabel , , , =?windows-1252?Q?Roger_Pau_Monn=E9?= Subject: Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies References: <1438711972-18752-1-git-send-email-julien.grall@citrix.com> <1438711972-18752-5-git-send-email-julien.grall@citrix.com> <55C33E4E.4050704@citrix.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/08/15 12:06, Stefano Stabellini wrote: > On Thu, 6 Aug 2015, Julien Grall wrote: >> Hi, >> >> >> On 04/08/15 19:12, Julien Grall wrote: >>> diff --git a/include/xen/page.h b/include/xen/page.h >>> index c5ed20b..e7e1425 100644 >>> --- a/include/xen/page.h >>> +++ b/include/xen/page.h >>> @@ -3,9 +3,9 @@ >>> >>> #include >>> >>> -static inline unsigned long page_to_mfn(struct page *page) >>> +static inline unsigned long page_to_gfn(struct page *page) >>> { >>> - return pfn_to_mfn(page_to_pfn(page)); >>> + return pfn_to_gfn(page_to_pfn(page)); >>> } >> >> I've just noticed that there is a function gfn_to_page used for KVM. >> >> Maybe I should rename page_to_gfn to xen_page_to_gfn to avoid confusion >> with KVM one? > > Yeah, prepending xen would help to avoid namespace pollution. Will do. May I keep your Reviewed-by for this mechanical change? Regards, -- Julien Grall From mboxrd@z Thu Jan 1 00:00:00 1970 From: julien.grall@citrix.com (Julien Grall) Date: Thu, 6 Aug 2015 12:17:36 +0100 Subject: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies In-Reply-To: References: <1438711972-18752-1-git-send-email-julien.grall@citrix.com> <1438711972-18752-5-git-send-email-julien.grall@citrix.com> <55C33E4E.4050704@citrix.com> Message-ID: <55C34250.3040801@citrix.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/08/15 12:06, Stefano Stabellini wrote: > On Thu, 6 Aug 2015, Julien Grall wrote: >> Hi, >> >> >> On 04/08/15 19:12, Julien Grall wrote: >>> diff --git a/include/xen/page.h b/include/xen/page.h >>> index c5ed20b..e7e1425 100644 >>> --- a/include/xen/page.h >>> +++ b/include/xen/page.h >>> @@ -3,9 +3,9 @@ >>> >>> #include >>> >>> -static inline unsigned long page_to_mfn(struct page *page) >>> +static inline unsigned long page_to_gfn(struct page *page) >>> { >>> - return pfn_to_mfn(page_to_pfn(page)); >>> + return pfn_to_gfn(page_to_pfn(page)); >>> } >> >> I've just noticed that there is a function gfn_to_page used for KVM. >> >> Maybe I should rename page_to_gfn to xen_page_to_gfn to avoid confusion >> with KVM one? > > Yeah, prepending xen would help to avoid namespace pollution. Will do. May I keep your Reviewed-by for this mechanical change? Regards, -- Julien Grall