From: Peter Hurley <peter@hurleysoftware.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Werner <andreas.werner@men.de>
Subject: Re: [PATCHv2 1/2] tty: serial: men_z135_uart.c: Fix race between IRQ and set_termios()
Date: Thu, 06 Aug 2015 07:29:18 -0400 [thread overview]
Message-ID: <55C3450E.8070107@hurleysoftware.com> (raw)
In-Reply-To: <535885237699310100f3e6804b3677495634042e.1438844880.git.jthumshirn@suse.de>
On 08/06/2015 03:16 AM, Johannes Thumshirn wrote:
> Fix panic caused by a race between men_z135_intr() and men_z135_set_termios().
>
> men_z135_intr() and men_z135_set_termios() both hold the struct uart_port::lock
> spinlock, but men_z135_intr() does a spin_lock_irqsave() and
> men_z135_set_termios() does a normal spin_lock(), which can lead to a deadlock
> when an interrupt is called while the lock is being helt by
> men_z135_set_termios().
>
> This was discovered using a insmod, hardware looppback send/receive, rmmod
> stress test.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
prev parent reply other threads:[~2015-08-06 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 7:16 [PATCHv2 0/2] tty: serial: men_z135_uart.c: Updates for men_z135_uart Johannes Thumshirn
2015-08-06 7:16 ` [PATCH 2/2] tty: serial: men_z135_uart.c: Don't initialize port->lock Johannes Thumshirn
2015-08-06 11:29 ` Peter Hurley
[not found] ` <535885237699310100f3e6804b3677495634042e.1438844880.git.jthumshirn@suse.de>
2015-08-06 11:29 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C3450E.8070107@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=andreas.werner@men.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.