From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZNM5a-0003X6-Io for mharc-grub-devel@gnu.org; Thu, 06 Aug 2015 10:24:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNM5T-0003Ql-7N for grub-devel@gnu.org; Thu, 06 Aug 2015 10:24:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNM5N-0001FX-Fb for grub-devel@gnu.org; Thu, 06 Aug 2015 10:24:03 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:45875 helo=mx0a-00082601.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNM5N-0001F3-9U for grub-devel@gnu.org; Thu, 06 Aug 2015 10:23:57 -0400 Received: from pps.filterd (m0004003 [127.0.0.1]) by mx0b-00082601.pphosted.com (8.14.5/8.14.5) with SMTP id t76EL5H8031022 for ; Thu, 6 Aug 2015 07:23:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=message-id : date : from : mime-version : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=4e2JuWf6myt1Ysu0hMJM6O4KW7w6+c72uUGo6cdPn2A=; b=pMt+sh8Z19DTglxqC2ex09oUPxD3h/6TcDJbMgkD6AFWWW0eBn/2q6aueG6ZMD5iuwMm s1bguipQxqoZvw85fgWb9DVjPBlYaLgCZGm3hvmmGeh/OBzJOQEeZp1IP+OAiZpeHFpt PHMoM2Pk4BbeQoZDP7ex+24gFbqJGTy4cdQ= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0b-00082601.pphosted.com with ESMTP id 1w4900g2ss-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT) for ; Thu, 06 Aug 2015 07:23:55 -0700 Received: from localhost.localdomain (192.168.54.13) by mail.thefacebook.com (192.168.16.16) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Aug 2015 07:23:54 -0700 Message-ID: <55C36DF8.1040008@fb.com> Date: Thu, 6 Aug 2015 10:23:52 -0400 From: Josef Bacik User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Subject: Re: [PATCH 0/3] fix ipv6 support References: <1438797040-1667541-1-git-send-email-jbacik@fb.com> <20150806040632.GA12717@linux-dsax.tai.apac.novell.com> In-Reply-To: <20150806040632.GA12717@linux-dsax.tai.apac.novell.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151, 1.0.33, 0.0.0000 definitions=2015-08-06_08:2015-08-06, 2015-08-06, 1970-01-01 signatures=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 67.231.153.30 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2015 14:24:04 -0000 On 08/06/2015 12:06 AM, Michael Chang wrote: > On Wed, Aug 05, 2015 at 10:50:37AM -0700, Josef Bacik wrote: >> These patches are on top of Michael Chang's bootp6 code (which we also really >> need so it would be great if those could go in as well). At Facebook we have >> ipv6 only clusters that we need to be able to provision over the network. The >> current grub2 support for ipv6 is broken in a few ways. The routing stuff >> needed to be reworked to handle talking to an ipv6 router properly. I tried to >> not change the code too much in order to make sure I didn't regress the ipv4 >> support. > > Thanks for your feedback, that's very encouraging to me. :-) > > The patch is still in review and need to solve some issues addressed by > Andrei. I was distracted by some other stuff later and my own server > hosted virtual machine to develope and test ipv6 was accidently broken > by system update of virtualization package. The major changes that cause > the failure seems to be qemu changes to enable ipxe UEFI option rom > which somehow did not provide ipv6 support in it's UNDI driver, along > with some other issues in edk2/ovmf itself. > > Anyway boop6 patches seems to be innocent to the new problem I have and > can continue the work by not loading iPXE UEFI option rom from qemu. To > whom who may be interested here is libvirt guest config I use to disable > option rom and use edk2's network stack. > > > > > > I will continue on working on the patches and follow through review for > the patch set with upstream. > That would be great, anything you post I'll pull in immediately and test on real hardware in one of our ipv6 only clusters to make sure it's still working. From my perspective none of your code has given me any problems, it pulls the dhcp information that uefi has already properly, and manually doing the bootp thing also works properly. Thanks, Josef