From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZNM7x-00048j-8S for mharc-grub-devel@gnu.org; Thu, 06 Aug 2015 10:26:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNM7s-00047X-Uv for grub-devel@gnu.org; Thu, 06 Aug 2015 10:26:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNM7o-0002GV-Tb for grub-devel@gnu.org; Thu, 06 Aug 2015 10:26:32 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:36621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNM7o-0002GK-M9 for grub-devel@gnu.org; Thu, 06 Aug 2015 10:26:28 -0400 Received: from pps.filterd (m0004348 [127.0.0.1]) by m0004348.ppops.net (8.14.5/8.14.5) with SMTP id t76EOZH7031578; Thu, 6 Aug 2015 07:26:27 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=message-id : date : from : mime-version : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=qQxWg/TzESdQ2PYRpSqTH0GiUGXVjbRnk6FX1qftAZs=; b=SWTnxxwWAIvtX7LpTJ5r97sC25uD9DXDK3gj8xgpn8eO72OIXypbtGlGp4r4g8cbUEFO mXtyLtv2RnS8ZFes9SFUaCiSWLnnxcy+xhzQtn/oUwGB3ZndrL2SkRzd9oNe4wS4EZWm 5p3mDXpmKjwUb3NFoODPF6kRjJ44aqr7x/Y= Received: from mail.thefacebook.com ([199.201.64.23]) by m0004348.ppops.net with ESMTP id 1w46kd8bab-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 06 Aug 2015 07:26:27 -0700 Received: from localhost.localdomain (192.168.54.13) by mail.thefacebook.com (192.168.16.19) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Aug 2015 07:26:25 -0700 Message-ID: <55C36E8F.40504@fb.com> Date: Thu, 6 Aug 2015 10:26:23 -0400 From: Josef Bacik User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: The development of GNU GRUB , "Vladimir 'phcoder' Serbinenko" Subject: Re: [PATCH 1/3] efinet: handle get_status() properly References: <1438799799-32097-1-git-send-email-jbacik@fb.com> <20150805230442.1bf65b2d@opensuse.site> <55C27179.6020104@fb.com> <20150806064200.49ef8397@opensuse.site> In-Reply-To: <20150806064200.49ef8397@opensuse.site> Content-Type: text/plain; charset="utf-8"; format=flowed X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151, 1.0.33, 0.0.0000 definitions=2015-08-06_08:2015-08-06, 2015-08-06, 1970-01-01 signatures=0 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by m0004348.ppops.net id t76EOZH7031578 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 67.231.145.42 Cc: mchang@suse.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2015 14:26:35 -0000 On 08/05/2015 11:42 PM, Andrei Borzenkov wrote: > =D0=92 Wed, 5 Aug 2015 22:32:13 +0200 > "Vladimir 'phcoder' Serbinenko" =D0=BF=D0=B8=D1=88=D0= =B5=D1=82: > >> This patch improperly assumes that GRUB is the only thing in EFI that >> transmits. > > Actually since recently we try to ensure that grub *is* the only user > of network interface. > >> Your patch surely fixed your machine but likely breaks some >> other machines. Could you instead make an explicit check for (void *)1= and >> add a comment on which machine it's necessary? > > Yes, this patch should add verbose comment to code explaining a) what > problem it tries to fix and b) why ignoring EFI specification is > justified here. Also mention actual hardware/firmware implementation > where this bug happens for future reference. > > Looking at other implementations gPXE opens SNP non-exclusively and > explicitly checks returned address. That corresponds to what grub > did in the past. iPXE opens SNP exclusively and assumes anything !=3D > NULL means transmit completed (it seems to start off with gPXE model). Ok I'll add a comment and resend the patch as it is. Thanks, Josef