Re: [review-request][PATCH] toastergui: Add tests for xhr_importlayer

[Michael Wood <michael.g.wood@intel.com>]

Couple of comments inline:

On 05/08/15 13:57, Sujith H wrote:
> Inorder to make sure if layer name which we import is already
> available in toaster database, a test case has been included.
> This would help user to identify if layer name which has been
> provided in the import layer web page already exists or not.
>
> Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
> Signed-off-by: Sujith Haridasan <Sujith_Haridasan@mentor.com>
> ---
>   bitbake/lib/toaster/toastergui/tests.py | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
>
> diff --git a/bitbake/lib/toaster/toastergui/tests.py b/bitbake/lib/toaster/toastergui/tests.py
> index 77e80fe..c4db145 100644
> --- a/bitbake/lib/toaster/toastergui/tests.py
> +++ b/bitbake/lib/toaster/toastergui/tests.py
> @@ -75,3 +75,21 @@ class XHRDataTypeAheadTestCase(ProvisionedLayersProjectTestCase):
>           self.assertTrue(len(data["list"]) > 0)
>   
>           self.assertTrue(XHRDataTypeAheadTestCase.LAYER_NAME in map(lambda x: x["name"], data["list"]))
> +
> +
> +class XHRImportLayerTestCase(ProvisionedLayersProjectTestCase):
> +
> +    def setUp(self):
> +        super(XHRImportLayerTestCase, self).setUp()
> +        self.assertTrue(self.lv in self.project.compatible_layerversions())
> +
> +    def test_import(self):
> +        data = {'vcs_url' : "/home/sujith/MEL/toaster_work/meta-oe" ,
Could you use a faked vcs_url value, e.g. "git://git.example.com/test"

> +                'name' : "base-layer", 'git_ref': "c12b9596afd236116b25ce26dbe0d793de9dc7ce",
> +                'project_id': 1, 'dir_path' : "/home/sujith/MEL/toaster_work/meta-oe/meta-oe"}
Same with this one, dir_path can be "/path/in/repository"
> +        result  = self.client.post(reverse('xhr_importlayer'), data, HTTP_X_REQUESTED_WITH='XMLHttpRequest')
I don't think HTTP_X_REQUESTED_WITH really needs setting, the default 
should be fine.
> +        self.assertEqual(result.status_code,200)
> +        self.assertTrue("hint-layer-exists-with-different-url" in result.content)
> +        data['name'] = "meta-oe"
> +        result  = self.client.post(reverse('xhr_importlayer'), data, HTTP_X_REQUESTED_WITH='XMLHttpRequest')
> +        self.assertTrue('"error": "ok"' in result.content)
Some new lines between the logical parts in the test would be good.

It would be great to cover these two conditions as well:

{"error": "Missing parameters; requires vcs_url, name, git_ref and 
project_id"}
{"error": "Invalid character <"}

Thanks,

Michael