From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [RFC PATCH 1/8] drm: exynos/dp: fix code style Date: Thu, 6 Aug 2015 23:20:48 +0800 Message-ID: <55C37B50.6050706@rock-chips.com> References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <1438869866-23028-1-git-send-email-ykk@rock-chips.com> <1438873536.2679.61.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1438873536.2679.61.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joe Perches Cc: Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, Andrzej Hajda , Gustavo Padovan , Ajay Kumar , linux-samsung-soc@vger.kernel.org, Vincent Palatin , linux-rockchip@lists.infradead.org, Kukjin Kim , Russell King , Thierry Reding , dianders@google.com, linux-arm-kernel@lists.infradead.org, Fabio Estevam , Jingoo Han , Seung-Woo Kim , linux-kernel@vger.kernel.org, Kyungmin Park , djkurtz@google.com, Andy Yan List-Id: linux-rockchip.vger.kernel.org Sm9lLAoK5ZyoIDIwMTUvOC82IDIzOjA1LCBKb2UgUGVyY2hlcyDlhpnpgZM6Cj4gT24gVGh1LCAy MDE1LTA4LTA2IGF0IDA5OjA0IC0wNTAwLCBZYWtpciBZYW5nIHdyb3RlOgo+PiBtYWtlIGNoZWNr cGF0Y2gucGwgc2NyaXB0IGhhcHB5Cj4gVGhhdCBzaG91bGQgbm90IGJlIHRoZSBwcmltYXJ5IHJl YXNvbiB0byBzdWJtaXQgYSBwYXRjaC4KPgo+IE1ha2luZyBpdCBlYXNpZXIgZm9yIGh1bWFuIGNv ZGUgcmVhZGVyIHRvIHVuZGVyc3RhbmQKPiB3aGF0IHRoZSBjb2RlIGRvZXMgc2hvdWxkIGJlIHRo b3VnaC4KVGhhbmtzIGZvciB5b3VyIHJlcGx5LCBidXQgSSBkbyB0aGluayB0aGF0IGZpeCBjb2Rl IHN0eWxlIGFuZCBtYWtlIApjaGVja3BhdGNoLnBsIHBhc3NlZCBpcyBteSBwcmltYXJ5IHJlYXNv biB0byBzdWJtaXQgdGhpcyBwYXRjaC4gSSBjYW4ndCAKdGhpbmsgb3V0IG1vcmUgZGlyZWN0bHkg d29yZHMgOyggLAoKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9z X2RwX2NvcmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RwX2NvcmUuYwo+IFtd Cj4+IEBAIC0xMjMsMTAgKzEyMywxMSBAQCBzdGF0aWMgaW50IGV4eW5vc19kcF9yZWFkX2VkaWQo c3RydWN0IGV4eW5vc19kcF9kZXZpY2UgKmRwKQo+PiAgIAkJZGV2X2RiZyhkcC0+ZGV2LCAiRURJ RCBkYXRhIGluY2x1ZGVzIGEgc2luZ2xlIGV4dGVuc2lvbiFcbiIpOwo+PiAgIAo+PiAgIAkJLyog UmVhZCBFRElEIGRhdGEgKi8KPj4gLQkJcmV0dmFsID0gZXh5bm9zX2RwX3JlYWRfYnl0ZXNfZnJv bV9pMmMoZHAsIEkyQ19FRElEX0RFVklDRV9BRERSLAo+PiAtCQkJCQkJRURJRF9IRUFERVJfUEFU VEVSTiwKPj4gLQkJCQkJCUVESURfQkxPQ0tfTEVOR1RILAo+PiAtCQkJCQkJJmVkaWRbRURJRF9I RUFERVJfUEFUVEVSTl0pOwo+PiArCQlyZXR2YWwgPQo+PiArCQlleHlub3NfZHBfcmVhZF9ieXRl c19mcm9tX2kyYyhkcCwgSTJDX0VESURfREVWSUNFX0FERFIsCj4+ICsJCQkJCSAgICAgIEVESURf SEVBREVSX1BBVFRFUk4sCj4+ICsJCQkJCSAgICAgIEVESURfQkxPQ0tfTEVOR1RILAo+PiArCQkJ CQkgICAgICAmZWRpZFtFRElEX0hFQURFUl9QQVRURVJOXSk7Cj4gVGhpcyBpcyBhIHJlbGF0aXZl bHkgdW5jb21tb24gc3R5bGUuCj4KPiBCZWNhdXNlIHRoZSBjb2RlIHVzZXMgcmVsYXRpdmVseSBs b25nIHZhcmlhYmxlIGFuZAo+IGZ1bmN0aW9uIG5hbWVzIGFzIHdlbGwgYXMgbG9uZ2lzaCBtYWNy byAjZGVmaW5lcywKPiBwcmVmZXIgdG8gaWdub3JlIHRoZSA4MCBjb2x1bW4gbGltaXQuCk9rYXks IEkgdGhpbmsgaXQgd291bGQgYmUgYmV0dGVyIHRvIG1vZGlmeSBsaWtlIHRob3NlOgoKcmV0dmFs ID0gZXh5bm9zX2RwX3JlYWRfYnl0ZXNfZnJvbV9pMmMoCgkJZHAsIEkyQ19FRElEX0RFVklDRV9B RERSLAoJCUVESURfSEVBREVSX1BBVFRFUk4sCgkJRURJRF9CTE9DS19MRU5HVEgsCgkJJmVkaWRb RURJRF9IRUFERVJfUEFUVEVSTl0pOwoKCklzIGl0IG9rYXkgPwoKLSBZYWtpcgo+Cj4KPgo+CgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Thu, 6 Aug 2015 23:20:48 +0800 Subject: [RFC PATCH 1/8] drm: exynos/dp: fix code style In-Reply-To: <1438873536.2679.61.camel@perches.com> References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <1438869866-23028-1-git-send-email-ykk@rock-chips.com> <1438873536.2679.61.camel@perches.com> Message-ID: <55C37B50.6050706@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Joe, ? 2015/8/6 23:05, Joe Perches ??: > On Thu, 2015-08-06 at 09:04 -0500, Yakir Yang wrote: >> make checkpatch.pl script happy > That should not be the primary reason to submit a patch. > > Making it easier for human code reader to understand > what the code does should be though. Thanks for your reply, but I do think that fix code style and make checkpatch.pl passed is my primary reason to submit this patch. I can't think out more directly words ;( , >> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c > [] >> @@ -123,10 +123,11 @@ static int exynos_dp_read_edid(struct exynos_dp_device *dp) >> dev_dbg(dp->dev, "EDID data includes a single extension!\n"); >> >> /* Read EDID data */ >> - retval = exynos_dp_read_bytes_from_i2c(dp, I2C_EDID_DEVICE_ADDR, >> - EDID_HEADER_PATTERN, >> - EDID_BLOCK_LENGTH, >> - &edid[EDID_HEADER_PATTERN]); >> + retval = >> + exynos_dp_read_bytes_from_i2c(dp, I2C_EDID_DEVICE_ADDR, >> + EDID_HEADER_PATTERN, >> + EDID_BLOCK_LENGTH, >> + &edid[EDID_HEADER_PATTERN]); > This is a relatively uncommon style. > > Because the code uses relatively long variable and > function names as well as longish macro #defines, > prefer to ignore the 80 column limit. Okay, I think it would be better to modify like those: retval = exynos_dp_read_bytes_from_i2c( dp, I2C_EDID_DEVICE_ADDR, EDID_HEADER_PATTERN, EDID_BLOCK_LENGTH, &edid[EDID_HEADER_PATTERN]); Is it okay ? - Yakir > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754043AbbHFPVd (ORCPT ); Thu, 6 Aug 2015 11:21:33 -0400 Received: from regular1.263xmail.com ([211.150.99.132]:39103 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751235AbbHFPVb (ORCPT ); Thu, 6 Aug 2015 11:21:31 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 220.249.180.47 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <13874cd47adfad36510f0841544b2f8f> X-DNS-TYPE: 0 Subject: Re: [RFC PATCH 1/8] drm: exynos/dp: fix code style To: Joe Perches References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <1438869866-23028-1-git-send-email-ykk@rock-chips.com> <1438873536.2679.61.camel@perches.com> Cc: Heiko Stuebner , Russell King , Fabio Estevam , Jingoo Han , Inki Dae , djkurtz@google.com, dianders@google.com, Takashi Iwai , Andrzej Hajda , Thierry Reding , Philipp Zabel , David Airlie , Gustavo Padovan , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Kukjin Kim , Ajay Kumar , Joonyoung Shim , Vincent Palatin , Mark Yao , Andy Yan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <55C37B50.6050706@rock-chips.com> Date: Thu, 6 Aug 2015 23:20:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1438873536.2679.61.camel@perches.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe, 在 2015/8/6 23:05, Joe Perches 写道: > On Thu, 2015-08-06 at 09:04 -0500, Yakir Yang wrote: >> make checkpatch.pl script happy > That should not be the primary reason to submit a patch. > > Making it easier for human code reader to understand > what the code does should be though. Thanks for your reply, but I do think that fix code style and make checkpatch.pl passed is my primary reason to submit this patch. I can't think out more directly words ;( , >> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c > [] >> @@ -123,10 +123,11 @@ static int exynos_dp_read_edid(struct exynos_dp_device *dp) >> dev_dbg(dp->dev, "EDID data includes a single extension!\n"); >> >> /* Read EDID data */ >> - retval = exynos_dp_read_bytes_from_i2c(dp, I2C_EDID_DEVICE_ADDR, >> - EDID_HEADER_PATTERN, >> - EDID_BLOCK_LENGTH, >> - &edid[EDID_HEADER_PATTERN]); >> + retval = >> + exynos_dp_read_bytes_from_i2c(dp, I2C_EDID_DEVICE_ADDR, >> + EDID_HEADER_PATTERN, >> + EDID_BLOCK_LENGTH, >> + &edid[EDID_HEADER_PATTERN]); > This is a relatively uncommon style. > > Because the code uses relatively long variable and > function names as well as longish macro #defines, > prefer to ignore the 80 column limit. Okay, I think it would be better to modify like those: retval = exynos_dp_read_bytes_from_i2c( dp, I2C_EDID_DEVICE_ADDR, EDID_HEADER_PATTERN, EDID_BLOCK_LENGTH, &edid[EDID_HEADER_PATTERN]); Is it okay ? - Yakir > > > >