All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fdt: add new fdt address parsing functions
Date: Thu, 06 Aug 2015 15:35:05 -0600	[thread overview]
Message-ID: <55C3D309.2010308@wwwdotorg.org> (raw)
In-Reply-To: <1438896662-27510-1-git-send-email-swarren@wwwdotorg.org>

On 08/06/2015 03:31 PM, Stephen Warren wrote:
> fdtdec_get_addr_size() hard-codes the number of cells used to represent
> an address or size in DT. This is incorrect in many cases depending on
> the DT binding for a particular node or property (e.g. it is incorrect
> for the "reg" property). In most cases, DT parsing code must use the
> properties #address-cells and #size-cells to parse addres properties.
>
> This change splits up the implementation of fdtdec_get_addr_size() so
> that the core logic can be used for both hard-coded and non-hard-coded
> cases. Various wrapper functions are implemented that support cases
> where hard-coded cell counts should or should not be used, and where
> the client does and doesn't know the parent node ID that contains the
> properties #address-cells and #size-cells.

> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
> index 95b59b586ff0..3afec045e9bd 100644
> --- a/lib/fdtdec.c
> +++ b/lib/fdtdec.c
> @@ -1,3 +1,5 @@
> +#define DEBUG
> +
>   /*

Uggh. That part will of course have to be dropped, but I'll hold off 
resending in case there are any other comments.

  reply	other threads:[~2015-08-06 21:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-06 21:31 [U-Boot] [PATCH] fdt: add new fdt address parsing functions Stephen Warren
2015-08-06 21:35 ` Stephen Warren [this message]
2015-08-09 15:07 ` Simon Glass
2015-09-07  8:22 ` Mugunthan V N
2015-09-09 18:08   ` Simon Glass
2015-09-11 10:54     ` Mugunthan V N
2015-09-15  7:55       ` Mugunthan V N
2015-09-15 19:17         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C3D309.2010308@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.