Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver

From: Yakir Yang <ykk@rock-chips.com>
To: Ajay kumar <ajaynumb@gmail.com>, Sean Paul <seanpaul@google.com>,
	Sean Paul <seanpaul@chromium.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	Ajay Kumar <ajaykumar.rs@samsung.com>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	Vincent Palatin <vpalatin@chromium.org>,
	"linux-rockchip@lists.infradead.org"
	<linux-rockchip@lists.infradead.org>,
	Kukjin Kim <kgene@kernel.org>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Thierry Reding <treding@nvidia.com>,
	"dianders@google.com" <dianders@google.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Kyungmin Park <kyungmin.park@s>
Subject: Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver
Date: Fri, 7 Aug 2015 16:17:43 +0800	[thread overview]
Message-ID: <55C469A7.90507@rock-chips.com> (raw)
In-Reply-To: <CAEC9eQNBU4oQnAFtWRNJonHOB-1XNhCO0r7fUiHohBErJE_sFQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2588 bytes --]

Ajay,

在 2015/8/7 14:11, Ajay kumar 写道:
> +Sean
>

Woh, okay, I will loop you and Sean to cc list in follow versions ;)

-Yakir
> On Thursday, August 6, 2015, Yakir Yang <ykk@rock-chips.com 
> <mailto:ykk@rock-chips.com>> wrote:
>
>     Jingoo,
>
>     在 2015/8/6 22:41, Jingoo Han 写道:
>
>         On Thursday, August 06, 2015 10:49 PM, Yakir Yang wrote:
>
>             Hi all,
>                 Samsung exynos and Rockchip rk3288 almost share same
>             dp controller,
>             so I split the common code out, then rk3288 and exynos can
>             re-used the
>             same dp core driver. Cause I can't find the exact IP name
>             of exynos dp
>             controller, so I decide to name dp core driver with
>             "analogix" which I
>             find in rk3288 eDP TRM ;)
>
>
>         OK, I see.
>         The Samsung Exynos eDP contoller and Rockchip rk3288 eDP
>         contoller share
>         the same IP. So, a lot of parts can be re-used. I agree with this.
>         However, we have to review the code carefully, as others did.
>
>     Yeah, feel happy to be reviewed  ;)
>
>         I also cannot find the exact IP name. The "analogix" may be
>         the vendor name
>         of this IP.
>
>     Okay, so "analogix" is okay for now
>
>     Thanks,
>     - Yakir
>
>         Best regards,
>         Jingoo Han
>
>             Beyond that, there are three light registers setting
>             differents bewteen
>             exynos and rk3288.
>             1. RK3288 have five special pll resigters which not
>             indicata in exynos
>                 dp controller.
>             2. The address of DP_PHY_PD(dp phy power manager register)
>             are different
>                 between rk3288 and exynos.
>             3. Rk3288 and exynos have different setting with
>             AUX_HW_RETRY_CTL(dp debug
>                 register).
>
>             My series patches can be divider into two parts: One for
>             spliting the
>             analogix_dp code from exynos dp driver. Another are trying
>             to add rk3288
>             dp driver support.
>
>             Best regards,
>             - Yakir
>
>
>             --
>             2.1.2
>
>
>
>
>
>
>
>     --
>     To unsubscribe from this list: send the line "unsubscribe
>     linux-samsung-soc" in
>     the body of a message to majordomo@vger.kernel.org
>     More majordomo info at http://vger.kernel.org/majordomo-info.html
>


[-- Attachment #1.2: Type: text/html, Size: 4598 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel