Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h

[Marc Zyngier <marc.zyngier@arm.com>]

Hi Ben,

On 07/08/15 06:31, Ben Zhang wrote:
> linux/io.h is needed because the driver uses:
> readl_relaxed
> writel_relaxed
> writeq_relaxed
> readq_relaxed
> iounmap
> 
> The header was implicitly included by an unrelated
> commit 332fd7c4fef5
> ("genirq: Generic chip: Change irq_reg_{readl,writel} arguments")
> from the path below:
> include/linux/io.h
> include/linux/irq.h
> include/linux/of_irq.h
> drivers/irqchip/irq-gic-v3.c
> 
> Signed-off-by: Ben Zhang <benzh@chromium.org>
> ---
>  drivers/irqchip/irq-gic-v3.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index e406bc5..3350b8d 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -19,6 +19,7 @@
>  #include <linux/cpu_pm.h>
>  #include <linux/delay.h>
>  #include <linux/interrupt.h>
> +#include <linux/io.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>
>  #include <linux/of_irq.h>
> 

This seems valid, but out of curiosity: Has this triggered any
observable build failure? Or is that something you found by inspection?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...