Re: [PATCH] mmc: sdhci: fix dma memory leak in sdhci_pre_req()

[Jiri Slaby <jslaby@suse.cz>]

On 08/07/2015, 11:29 AM, Haibo Chen wrote:
> Currently one mrq->data maybe execute dma_map_sg() twice
> when mmc subsystem prepare over one new request, and the
> following log show up:
> 	sdhci[sdhci_pre_dma_transfer] invalid cookie: 24, next-cookie 25

Thanks, I will test it shortly.

> @@ -2157,16 +2147,10 @@ static void sdhci_pre_req(struct mmc_host *mmc, struct mmc_request *mrq,
>  {
>  	struct sdhci_host *host = mmc_priv(mmc);
>  
> -	if (mrq->data->host_cookie) {
> -		mrq->data->host_cookie = 0;
> -		return;
> -	}
> +	mrq->data->host_cookie = COOKIE_UNMAPPED;

Just one question. Should we warn if host_cookie != COOKIE_UNMAPPED
instead of the assignment? In other words, if the assignment is
mandatory, it deserves a comment why.

thanks,
-- 
js
suse labs