From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v4 01/31] libxl: fix libxl__build_hvm error
	handling
Date: Fri, 7 Aug 2015 12:55:21 +0200
Message-ID: <55C48E99.3050606@citrix.com>
References: <1438942688-7610-1-git-send-email-roger.pau@citrix.com>
	<1438942688-7610-2-git-send-email-roger.pau@citrix.com>
	<20150807104922.GD6005@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=654947d1e=roger.pau@citrix.com>)
	id 1ZNfJ9-0004n8-RJ
	for xen-devel@lists.xenproject.org; Fri, 07 Aug 2015 10:55:27 +0000
In-Reply-To: <20150807104922.GD6005@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

El 07/08/15 a les 12.49, Wei Liu ha escrit:
> On Fri, Aug 07, 2015 at 12:17:38PM +0200, Roger Pau Monne wrote:
>> With the current code in libxl__build_hvm it is possible for the function to
>> fail and still return 0.
> 
> It's hard to see where the bug is when this patch also does a bunch of
> refactoring.

It refactors the error paths only, mainly replacing:

if (libxl_call_foo(bar))
    <error>

to

rc = libxl_call_foo(bar)
if (rc != 0)
    <error>

So we can keep the error codes returned by auxiliary functions.

> It would be good if you can separate the bug fix from other name
> changing bits, so that we can apply that bug fix for 4.6 possibly queue
> it up for backporting.

There are no name changing bits AFAICT.

Roger.