From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-x231.google.com (mail-ig0-x231.google.com [IPv6:2607:f8b0:4001:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 9C2A71A001E for ; Sat, 8 Aug 2015 00:00:58 +1000 (AEST) Received: by igbij6 with SMTP id ij6so31526651igb.1 for ; Fri, 07 Aug 2015 07:00:56 -0700 (PDT) Message-ID: <55C4BA14.8020307@gmail.com> Date: Fri, 07 Aug 2015 10:00:52 -0400 From: nick MIME-Version: 1.0 To: Paolo Bonzini , agraf@suse.com CC: gleb@kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing References: <1438955228-30116-1-git-send-email-xerofoify@gmail.com> <55C4B9C0.5030102@redhat.com> In-Reply-To: <55C4B9C0.5030102@redhat.com> Content-Type: text/plain; charset=UTF-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2015-08-07 09:59 AM, Paolo Bonzini wrote: > > > On 07/08/2015 15:47, Nicholas Krause wrote: >> - kvm_set_irq_routing(opp->kvm, routing, 0, 0); >> + ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0); >> + if (ret) { >> + kfree(routing); >> + return ret; >> + } >> >> kfree(routing); >> return 0; > > You could just return ret here. The new "if" is not necessary. > > Paolo > Ok sure that seems fine to be and much simpler then this. Sorry about the wasting your time with this patch. Nick From mboxrd@z Thu Jan 1 00:00:00 1970 From: nick Subject: Re: [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing Date: Fri, 07 Aug 2015 10:00:52 -0400 Message-ID: <55C4BA14.8020307@gmail.com> References: <1438955228-30116-1-git-send-email-xerofoify@gmail.com> <55C4B9C0.5030102@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: gleb@kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org To: Paolo Bonzini , agraf@suse.com Return-path: In-Reply-To: <55C4B9C0.5030102@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org CgpPbiAyMDE1LTA4LTA3IDA5OjU5IEFNLCBQYW9sbyBCb256aW5pIHdyb3RlOgo+IAo+IAo+IE9u IDA3LzA4LzIwMTUgMTU6NDcsIE5pY2hvbGFzIEtyYXVzZSB3cm90ZToKPj4gLQlrdm1fc2V0X2ly cV9yb3V0aW5nKG9wcC0+a3ZtLCByb3V0aW5nLCAwLCAwKTsKPj4gKwlyZXQgPSBrdm1fc2V0X2ly cV9yb3V0aW5nKG9wcC0+a3ZtLCByb3V0aW5nLCAwLCAwKTsKPj4gKwlpZiAocmV0KSB7Cj4+ICsJ CWtmcmVlKHJvdXRpbmcpOwo+PiArCQlyZXR1cm4gcmV0Owo+PiArCX0KPj4gIAo+PiAgCWtmcmVl KHJvdXRpbmcpOwo+PiAgCXJldHVybiAwOwo+IAo+IFlvdSBjb3VsZCBqdXN0IHJldHVybiByZXQg aGVyZS4gIFRoZSBuZXcgImlmIiBpcyBub3QgbmVjZXNzYXJ5Lgo+IAo+IFBhb2xvCj4gCgpPayBz dXJlIHRoYXQgc2VlbXMgZmluZSB0byBiZSBhbmQgbXVjaCBzaW1wbGVyIHRoZW4gdGhpcy4KU29y cnkgYWJvdXQgdGhlIHdhc3RpbmcgeW91ciB0aW1lIHdpdGggdGhpcyBwYXRjaC4KTmljayAKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMtZGV2 IG1haWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3Rz Lm96bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMtZGV2