From: Eric Sandeen <sandeen@sandeen.net>
To: Brian Foster <bfoster@redhat.com>
Cc: Jan Tulak <jtulak@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] mkfs.xfs: fix ftype-vs-crc option combination testing
Date: Fri, 07 Aug 2015 09:42:47 -0700 [thread overview]
Message-ID: <55C4E007.90709@sandeen.net> (raw)
In-Reply-To: <20150807113742.GB8322@bfoster.bfoster>
On 8/7/15 4:37 AM, Brian Foster wrote:
> On Thu, Aug 06, 2015 at 10:18:50PM -0700, Eric Sandeen wrote:
>> mkfs.xfs got weird along the way; today it has different outcomes
>> depending on the order of option specification:
>>
>> $ mkfs/mkfs.xfs -n ftype=1 -m crc=0 -dfile,name=fsfile,size=16g
>> cannot specify both crc and ftype
>> $ mkfs/mkfs.xfs -m crc=0 -n ftype=1 -dfile,name=fsfile,size=16g
>> <succeeds>
>>
>> Somehow the tests got written as being constrained on what options
>> are specified - and in what order! - vs actually testing for
>> incompatible feature sets.
>>
>
> IIRC, I think this is one of the core problems the big mkfs option
> parsing rework that Jan is working on is supposed to fix.
Yeah, I think so - Jan, if this gets in your way, let us know -
I didn't mean to make your life difficult by fixing little
things while you work. :)
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-08-07 16:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 5:18 [PATCH] mkfs.xfs: fix ftype-vs-crc option combination testing Eric Sandeen
2015-08-07 11:37 ` Brian Foster
2015-08-07 16:42 ` Eric Sandeen [this message]
2015-08-13 11:14 ` Jan Tulak
2015-08-14 1:57 ` Dave Chinner
2015-08-14 6:12 ` Jan Tulak
2015-08-18 6:53 ` Dave Chinner
2015-08-18 15:36 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C4E007.90709@sandeen.net \
--to=sandeen@sandeen.net \
--cc=bfoster@redhat.com \
--cc=jtulak@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.