All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/dawgdic: needs gcc >= 4.7
Date: Sat, 8 Aug 2015 18:55:08 +0200	[thread overview]
Message-ID: <55C6346C.40707@openwide.fr> (raw)
In-Reply-To: <55C617D0.3050800@green-communications.fr>

Hi Nicolas,

Le 08/08/2015 16:53, Nicolas Cavallari a ?crit :
> On 08/08/2015 11:35, Romain Naour wrote:
>> std::strtoll is only supported since C++11.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/cae/cae3cda9be779ea8359f94d13bbbca97e68495ca/
>>
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>>   package/dawgdic/Config.in | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/dawgdic/Config.in b/package/dawgdic/Config.in
>> index ce0b466..8ef9902 100644
>> --- a/package/dawgdic/Config.in
>> +++ b/package/dawgdic/Config.in
>> @@ -1,6 +1,8 @@
>>   config BR2_PACKAGE_DAWGDIC
>>       bool "dawgdic"
>>       depends on BR2_INSTALL_LIBSTDCPP
>> +    # std=c11
>> +    depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
> The string conversion functions also exist in 4.6[1].
> 
> However, there is another problem: If an external toolchain is built using GCC
> and uclibc without any additional patches, then you will not have them, because
> of a too-broad feature check in libstdc++ that checks if the C library has
> complete support for C99[2].
> 
> This problem is still unresolved even with the latest GCC. buildroot patches GCC
> to fix this, but if an external toolchain does not ...
> 

Thanks for the report.

I followed the cppreference site:
http://en.cppreference.com/w/cpp/string/byte/strtol (C++11)

Since C++11 start with gcc 4.7, so I haven't looked further...
My bad.

Best regards,
Romain Naour

> [1]:
> https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=libstdc%2B%2B-v3/include/c_std/cstdlib;h=c3fe8aa4507d51375474c2914fb3e812b3a136e0;hb=632cb4d5f22f598d1395fbae90a10fb679e06054
> 
> 
> [2]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58393

      parent reply	other threads:[~2015-08-08 16:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-08  9:35 [Buildroot] [PATCH] package/dawgdic: needs gcc >= 4.7 Romain Naour
2015-08-08 10:06 ` Thomas Petazzoni
2015-08-08 14:53 ` Nicolas Cavallari
2015-08-08 15:14   ` Thomas Petazzoni
2015-08-11  9:04     ` Nicolas Cavallari
2015-08-08 16:55   ` Romain Naour [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C6346C.40707@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.