From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM Date: Sun, 9 Aug 2015 14:49:23 +0100 Message-ID: <55C75A63.3030906@citrix.com> References: <1438968438-23074-1-git-send-email-julien.grall@citrix.com> <20150808151632.GC14214@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZOQye-0001RU-EB for xen-devel@lists.xenproject.org; Sun, 09 Aug 2015 13:49:28 +0000 In-Reply-To: <20150808151632.GC14214@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Ian Jackson , xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Hi Wei, On 08/08/2015 16:16, Wei Liu wrote: > On Fri, Aug 07, 2015 at 06:27:18PM +0100, Julien Grall wrote: >> The firmware directory is not built at all on ARM. Attempting to update >> it using the target subtree-force-update will fail when try to update >> seabios. >> >> Signed-off-by: Julien Grall >> >> --- >> Cc: Ian Jackson >> Cc: Stefano Stabellini >> Cc: Ian Campbell >> Cc: Wei Liu >> >> I've noticed it while trying to update the QEMU tree used by Xen on >> a platform where iasl is not present (required by seabios in order >> to update it). >> >> I think this should go in Xen 4.6 and possibly backport to Xen 4.5 >> --- >> tools/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tools/Makefile b/tools/Makefile >> index 45cb4b2..2618559 100644 >> --- a/tools/Makefile >> +++ b/tools/Makefile >> @@ -305,7 +305,9 @@ endif >> ifeq ($(CONFIG_QEMU_TRAD),y) >> $(MAKE) qemu-xen-traditional-dir-force-update >> endif >> +ifeq ($(CONFIG_X86),y) >> $(MAKE) -C firmware subtree-force-update >> +endif >> > > This is not optimal. What if you want to build OVMF on arm in the > future? You also can't preclude you don't have any other firmwares that > need to be built on ARM in the future. > I think a proper way of doing this is to make CONFIG_SEABIOS=n when > you're building on ARM. See tools/configure.ac. tools/Makefile only build the firmware directory for x86 see: SUBDIRS-$(CONFIG_X86) += firmware Hence why I wrote the patch in the current way. Building the firmware directory for would require more work than replace SUBDIRS-$(CONFIG_X86) to SUBDIRS-y. In general, I do agree that we enable this with configure.ac but, IHMO this is not Xen 4.6 material... Although I would be happy to fix it for Xen 4.7. Regards, -- Julien Grall