From: Hans Verkuil <hverkuil@xs4all.nl>
To: Antti Palosaari <crope@iki.fi>, linux-media@vger.kernel.org
Subject: Re: [PATCHv3 12/13] DocBook: fix S_FREQUENCY => G_FREQUENCY
Date: Mon, 10 Aug 2015 11:41:13 +0200 [thread overview]
Message-ID: <55C871B9.2080207@xs4all.nl> (raw)
In-Reply-To: <1438308650-2702-13-git-send-email-crope@iki.fi>
On 07/31/2015 04:10 AM, Antti Palosaari wrote:
> It is VIDIOC_G_FREQUENCY which does not use type to identify tuner,
> not VIDIOC_S_FREQUENCY. VIDIOC_S_FREQUENCY uses both tuner and type
> fields. One of these V4L API weirdness...
Actually, that's not what this is about. It's about whether g/s_frequency gets/sets
the frequency for the tuner or the modulator. That has nothing to do with the tuner
and type fields. The problem described here in the spec is a problem for both G and
S_FREQUENCY.
Regards,
Hans
>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Signed-off-by: Antti Palosaari <crope@iki.fi>
> ---
> Documentation/DocBook/media/v4l/common.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/DocBook/media/v4l/common.xml b/Documentation/DocBook/media/v4l/common.xml
> index 8b5e014..f7008ea 100644
> --- a/Documentation/DocBook/media/v4l/common.xml
> +++ b/Documentation/DocBook/media/v4l/common.xml
> @@ -428,7 +428,7 @@ zero, no video outputs.</para>
> modulator. Two separate device nodes will have to be used for such
> hardware, one that supports the tuner functionality and one that supports
> the modulator functionality. The reason is a limitation with the
> -&VIDIOC-S-FREQUENCY; ioctl where you cannot specify whether the frequency
> +&VIDIOC-G-FREQUENCY; ioctl where you cannot specify whether the frequency
> is for a tuner or a modulator.</para>
>
> <para>To query and change modulator properties applications use
>
next prev parent reply other threads:[~2015-08-10 9:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 2:10 [PATCHv3 00/13] SDR transmitter API Antti Palosaari
2015-07-31 2:10 ` [PATCHv3 01/13] v4l2: rename V4L2_TUNER_ADC to V4L2_TUNER_SDR Antti Palosaari
2015-07-31 2:10 ` [PATCHv3 02/13] v4l2: add RF gain control Antti Palosaari
2015-08-10 8:56 ` Hans Verkuil
2015-07-31 2:10 ` [PATCHv3 03/13] DocBook: document tuner " Antti Palosaari
2015-08-10 8:57 ` Hans Verkuil
2015-07-31 2:10 ` [PATCHv3 04/13] v4l2: add support for SDR transmitter Antti Palosaari
2015-07-31 2:10 ` [PATCHv3 05/13] DocBook: document " Antti Palosaari
2015-07-31 2:10 ` [PATCHv3 06/13] v4l: add type field to v4l2_modulator struct Antti Palosaari
2015-08-10 9:01 ` Hans Verkuil
2015-07-31 2:10 ` [PATCHv3 07/13] DocBook: add modulator type field Antti Palosaari
2015-08-10 9:02 ` Hans Verkuil
2015-07-31 2:10 ` [PATCHv3 08/13] hackrf: add control for RF amplifier Antti Palosaari
2015-08-10 9:03 ` Hans Verkuil
2015-07-31 2:10 ` [PATCHv3 09/13] hackrf: switch to single function which configures everything Antti Palosaari
2015-08-10 9:04 ` Hans Verkuil
2015-07-31 2:10 ` [PATCHv3 10/13] hackrf: add support for transmitter Antti Palosaari
2015-08-10 9:34 ` Hans Verkuil
2015-07-31 2:10 ` [PATCHv3 11/13] hackrf: do not set human readable name for formats Antti Palosaari
2015-07-31 2:10 ` [PATCHv3 12/13] DocBook: fix S_FREQUENCY => G_FREQUENCY Antti Palosaari
2015-08-10 9:41 ` Hans Verkuil [this message]
2015-08-11 2:55 ` Antti Palosaari
2015-07-31 2:10 ` [PATCHv3 13/13] DocBook: add tuner types SDR and RF for G_TUNER / S_TUNER Antti Palosaari
2015-08-10 9:43 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C871B9.2080207@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.