From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53489)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1ZOjlr-0001CE-03
	for qemu-devel@nongnu.org; Mon, 10 Aug 2015 05:53:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1ZOjlq-0002MS-4v
	for qemu-devel@nongnu.org; Mon, 10 Aug 2015 05:53:30 -0400
References: <1438334355-26914-1-git-send-email-wency@cn.fujitsu.com>
	<1438334355-26914-4-git-send-email-wency@cn.fujitsu.com>
	<w51pp2vimi4.fsf@maestria.local.igalia.com>
From: Wen Congyang <wency@cn.fujitsu.com>
Message-ID: <55C87483.6030103@cn.fujitsu.com>
Date: Mon, 10 Aug 2015 17:53:07 +0800
MIME-Version: 1.0
In-Reply-To: <w51pp2vimi4.fsf@maestria.local.igalia.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 3/6] Add new block driver interface
 to add/delete a BDS's child
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu devel <qemu-devel@nongnu.org>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu block <qemu-block@nongnu.org>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Yang Hongyang <yanghy@cn.fujitsu.com>

On 08/10/2015 04:19 PM, Alberto Garcia wrote:
> On Fri 31 Jul 2015 11:19:12 AM CEST, Wen Congyang wrote:
> 
>> +static const char *bdrv_get_id_or_node_name(BlockDriverState *bs)
>> +{
>> +    if (bs->blk) {
>> +        return blk_name(bs->blk);
>> +    }
>> +
>> +    return bs->node_name ? bs->node_name : "";
>> +}
> 
> You don't need to add this function, you can use
> bdrv_get_device_or_node_name() instead.

Yes, I will update it in the next version.

Thanks
Wen Congyang

> 
> Berto
> .
>