All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	<xen-devel@lists.xenproject.org>
Cc: David Vrabel <david.vrabel@citrix.com>,
	<linux-kernel@vger.kernel.org>, <ian.campbell@citrix.com>,
	<stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH v3 9/9] xen/xenbus: Rename the variable xen_store_mfn to xen_store_gfn
Date: Mon, 10 Aug 2015 10:59:02 +0100	[thread overview]
Message-ID: <55C875E6.7050909@citrix.com> (raw)
In-Reply-To: <55C52416.1090906@oracle.com>

Hi Boris,

On 07/08/2015 22:33, Boris Ostrovsky wrote:
> On 08/07/2015 12:34 PM, Julien Grall wrote:
>> The variable xen_store_mfn is effectively storing a GFN and not an MFN.
>>
>> Signed-off-by: Julien Grall <julien.grall@citrix.com>
>>
>> ---
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: David Vrabel <david.vrabel@citrix.com>
>>
>>      I think that the assignation of xen_start_info in
>>      xenstored_local_init is pointless. Although I haven't drop it just
>>      in case.
>
> I think so too (but that would be a separate patch if you decide to do it).

I will send a separate patch to drop it.

>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Thank you!

Regards,

-- 
Julien Grall

  parent reply	other threads:[~2015-08-10  9:59 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07 16:34 [PATCH v3 0/9] Use correctly the Xen memory terminologies Julien Grall
2015-08-07 16:34 ` Julien Grall
2015-08-07 16:34 ` Julien Grall
2015-08-07 16:34 ` Julien Grall
2015-08-07 16:34 ` Julien Grall
2015-08-07 16:34 ` [PATCH v3 1/9] arm/xen: Remove helpers which are PV specific Julien Grall
2015-08-07 16:34 ` Julien Grall
2015-08-07 16:34   ` Julien Grall
2015-08-07 16:34 ` [PATCH v3 2/9] xen: Make clear that swiotlb and biomerge are dealing with DMA address Julien Grall
2015-08-07 16:34 ` Julien Grall
2015-08-07 16:34   ` Julien Grall
2015-08-07 16:34 ` [PATCH v3 3/9] arm/xen: implement correctly pfn_to_mfn Julien Grall
2015-08-07 16:34   ` Julien Grall
2015-08-07 16:34 ` Julien Grall
2015-08-07 16:34 ` [PATCH v3 4/9] xen: Use correctly the Xen memory terminologies Julien Grall
2015-08-07 16:34 ` Julien Grall
2015-08-07 16:34   ` Julien Grall
2015-08-07 16:34   ` Julien Grall
2015-08-07 16:34   ` Julien Grall
2015-08-07 16:34   ` Julien Grall
2015-08-07 16:34 ` [PATCH v3 5/9] xen/tmem: Use xen_page_to_gfn rather than pfn_to_gfn Julien Grall
2015-08-07 16:34 ` Julien Grall
2015-08-07 16:34 ` [PATCH v3 6/9] video/xen-fbfront: Further s/MFN/GFN clean-up Julien Grall
2015-08-07 16:34   ` Julien Grall
2015-08-07 16:34 ` Julien Grall
2015-08-07 16:34 ` [PATCH v3 7/9] hvc/xen: " Julien Grall
2015-08-07 16:34 ` Julien Grall
2015-08-07 16:34 ` [PATCH v3 8/9] xen/privcmd: Further s/MFN/GFN/ clean-up Julien Grall
2015-08-07 16:34   ` Julien Grall
2015-08-07 16:34   ` Julien Grall
2015-08-07 16:34 ` [PATCH v3 9/9] xen/xenbus: Rename the variable xen_store_mfn to xen_store_gfn Julien Grall
2015-08-07 16:34   ` Julien Grall
2015-08-07 21:33   ` Boris Ostrovsky
2015-08-10  9:59     ` Julien Grall
2015-08-10  9:59     ` Julien Grall [this message]
2015-08-07 21:33   ` Boris Ostrovsky
2015-08-10 10:06   ` Stefano Stabellini
2015-08-10 10:06   ` Stefano Stabellini
2015-08-11 17:37 ` [Xen-devel] [PATCH v3 0/9] Use correctly the Xen memory terminologies David Vrabel
2015-08-11 17:37   ` David Vrabel
2015-08-11 17:37   ` David Vrabel
2015-08-11 17:37   ` David Vrabel
2015-08-11 17:37   ` David Vrabel
2015-08-11 17:37 ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C875E6.7050909@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.