All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Alban Crequy
	<alban.crequy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Alban Crequy <alban-973cpzSjLbNWk0Htik3J/w@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Iago Lopez Galeiras
	<iago-973cpzSjLbNWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] cpuset: use trialcs->mems_allowed as a temp variable
Date: Mon, 10 Aug 2015 18:25:13 +0800	[thread overview]
Message-ID: <55C87C09.7030207@huawei.com> (raw)
In-Reply-To: <20150807145907.GC14626-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>

On 2015/8/7 22:59, Tejun Heo wrote:
> On Thu, Aug 06, 2015 at 04:21:05PM +0200, Alban Crequy wrote:
>> The comment says it's using trialcs->mems_allowed as a temp variable but
>> it didn't match the code. Change the code to match the comment.
>>
>> This fixes an issue when writing in cpuset.mems when a sub-directory
>> exists: we need to write several times for the information to persist:
>>
>> | root@alban:/sys/fs/cgroup/cpuset# mkdir footest9
>> | root@alban:/sys/fs/cgroup/cpuset# cd footest9
>> | root@alban:/sys/fs/cgroup/cpuset/footest9# mkdir aa
>> | root@alban:/sys/fs/cgroup/cpuset/footest9# cat cpuset.mems
>> |
>> | root@alban:/sys/fs/cgroup/cpuset/footest9# echo 0 > cpuset.mems
>> | root@alban:/sys/fs/cgroup/cpuset/footest9# cat cpuset.mems
>> |
>> | root@alban:/sys/fs/cgroup/cpuset/footest9# echo 0 > cpuset.mems
>> | root@alban:/sys/fs/cgroup/cpuset/footest9# cat cpuset.mems
>> | 0
>> | root@alban:/sys/fs/cgroup/cpuset/footest9# cat aa/cpuset.mems
>> |
>> | root@alban:/sys/fs/cgroup/cpuset/footest9# echo 0 > aa/cpuset.mems
>> | root@alban:/sys/fs/cgroup/cpuset/footest9# cat aa/cpuset.mems
>> | 0
>> | root@alban:/sys/fs/cgroup/cpuset/footest9#
>>
>> This should help to fix the following issue in Docker:
>> https://github.com/opencontainers/runc/issues/133
>> In some conditions, a Docker container needs to be started twice in
>> order to work.
>>
>> Signed-off-by: Alban Crequy <alban-973cpzSjLbNWk0Htik3J/w@public.gmane.org>
>> Tested-by: Iago López Galeiras <iago-973cpzSjLbNWk0Htik3J/w@public.gmane.org>
>
> Li?
>

Acked.

Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # 3.17+

  parent reply	other threads:[~2015-08-10 10:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-06 14:21 [PATCH] cpuset: use trialcs->mems_allowed as a temp variable Alban Crequy
     [not found] ` <1438870865-25468-1-git-send-email-alban-973cpzSjLbNWk0Htik3J/w@public.gmane.org>
2015-08-07 14:59   ` Tejun Heo
     [not found]     ` <20150807145907.GC14626-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-08-10 10:25       ` Zefan Li [this message]
2015-08-10 15:19   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C87C09.7030207@huawei.com \
    --to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
    --cc=alban-973cpzSjLbNWk0Htik3J/w@public.gmane.org \
    --cc=alban.crequy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=iago-973cpzSjLbNWk0Htik3J/w@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.