From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Matthias Tafelmeier <matthias.tafelmeier@gmx.net>,
netdev@vger.kernel.org
Cc: hagen@jauu.net, shemminger@osdl.org, fw@strlen.de,
edumazet@google.com, daniel@iogearbox.net
Subject: Re: [PATCH 08/10] ss: symmetrical subhandler output extension example
Date: Mon, 10 Aug 2015 15:19:06 +0300 [thread overview]
Message-ID: <55C896BA.8040408@cogentembedded.com> (raw)
In-Reply-To: <1439162006-11421-9-git-send-email-matthias.tafelmeier@gmx.net>
On 8/10/2015 2:13 AM, Matthias Tafelmeier wrote:
> This small sized patch shall convey the locations which have to be
> changed for a symmetrical output extension. Symmetrical means in this
> context all existing semantically related handlers in the diverse
> formatters (for hr and json up to now).
> Signed-off-by: Matthias Tafelmeier <matthias.tafelmeier@gmx.net>
> Suggested-by: Hagen Paul Pfeifer <hagen@jauu.net>
[...]
> diff --git a/misc/ss_json_fmt.c b/misc/ss_json_fmt.c
> index f1a53cd..e80f063 100644
> --- a/misc/ss_json_fmt.c
> +++ b/misc/ss_json_fmt.c
> @@ -161,7 +161,9 @@ static void tcp_stats_json_fmt(struct tcpstat *s)
> if (s->rcv_rtt) {
> printf(",\n%s\"rcv_rtt\": %g", indent1, s->rcv_rtt);
> }
> -
> + if (s->rcv_space) {
> + printf(",\n%s\"rcv_space\": %d", indent1, s->rcv_space);
> + }
{} not needed. I guess you haven't run your patches thru
scripts/checkpatch.pl?
WBR, Sergei
next prev parent reply other threads:[~2015-08-10 12:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-09 23:13 full ss json support and general output simplification Matthias Tafelmeier
2015-08-09 23:13 ` [PATCH 01/10] ss: rooted out ss type declarations for output formatters Matthias Tafelmeier
2015-08-09 23:13 ` [PATCH 02/10] ss: created formatters for json and hr Matthias Tafelmeier
2015-08-09 23:13 ` [PATCH 03/10] ss: removed obsolet fmt functions Matthias Tafelmeier
2015-08-09 23:13 ` [PATCH 04/10] ss: prepare timer for output handler usage Matthias Tafelmeier
2015-08-09 23:13 ` [PATCH 05/10] ss: framed skeleton for json output in ss Matthias Tafelmeier
2015-08-09 23:13 ` [PATCH 06/10] ss: replaced old output mechanisms with fmt handlers interfaces Matthias Tafelmeier
2015-08-09 23:13 ` [PATCH 07/10] ss: renaming and export of current_filter Matthias Tafelmeier
2015-08-09 23:13 ` [PATCH 08/10] ss: symmetrical subhandler output extension example Matthias Tafelmeier
2015-08-10 12:19 ` Sergei Shtylyov [this message]
2015-08-10 14:53 ` Eric Dumazet
2015-08-10 17:06 ` Matthias Tafelmeier
2015-08-10 18:19 ` Sergei Shtylyov
2015-08-09 23:13 ` [PATCH 09/10] ss: symmetrical formatter " Matthias Tafelmeier
2015-08-09 23:13 ` [PATCH 10/10] ss: fixed free on local array for valid json output Matthias Tafelmeier
-- strict thread matches above, loose matches on Subject: below --
2015-08-10 18:52 V2 iproute2: full ss json support and general output simplification Matthias Tafelmeier
2015-08-10 18:52 ` [PATCH 08/10] ss: symmetrical subhandler output extension example Matthias Tafelmeier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C896BA.8040408@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=hagen@jauu.net \
--cc=matthias.tafelmeier@gmx.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.