From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH 9/9] drm: bridge/dw_hdmi-i2s-audio: add audio driver Date: Tue, 11 Aug 2015 00:26:21 +0800 Message-ID: <55C8D0AD.3040001@rock-chips.com> References: <20150808160936.GN7557@n2100.arm.linux.org.uk> <20150810154848.GV7557@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150810154848.GV7557@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux , linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Fabio Estevam , Jaroslav Kysela , Mark Brown , Andy Yan List-Id: alsa-devel@alsa-project.org SGkgUnVzc2VsbCwKCuWcqCAyMDE1LzgvMTAgMjM6NDgsIFJ1c3NlbGwgS2luZyAtIEFSTSBMaW51 eCDlhpnpgZM6Cj4gT24gU2F0LCBBdWcgMDgsIDIwMTUgYXQgMDU6MTA6NDdQTSArMDEwMCwgUnVz c2VsbCBLaW5nIHdyb3RlOgo+PiBGcm9tOiBZYWtpciBZYW5nIDx5a2tAcm9jay1jaGlwcy5jb20+ Cj4+Cj4+IEFkZCBBTFNBIGJhc2VkIEhETUkgSTJTIGF1ZGlvIGRyaXZlciBmb3IgZHdfaGRtaS4g U291bmQgY2FyZAo+PiBkcml2ZXIgY291bGQgY29ubmVjdCB0byB0aGlzIGNvZGVjIHRocm91Z2gg dGhlIGNvZGVjIGRhaSBuYW1lCj4+ICJkdy1oZG1pLWkycy1hdWRpbyIuCj4+Cj4+IFtGaXhlZCBJ UlEgbmFtZSwgTU9EVUxFX0RFU0NSSVBUSU9OLCBNT0RVTEVfQUxJQVMgaW4KPj4gICBkdy1oZG1p LWkycy1hdWRpby5jLCBhbmQgcGxhdGZvcm0gZGV2aWNlIG5hbWUgaW4gZHctaGRtaS5jIC0tcm1r XQo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBZYWtpciBZYW5nIDx5a2tAcm9jay1jaGlwcy5jb20+Cj4+ IFNpZ25lZC1vZmYtYnk6IFJ1c3NlbGwgS2luZyA8cm1rK2tlcm5lbEBhcm0ubGludXgub3JnLnVr Pgo+IEknbSBkcm9wcGluZyB0aGlzIHBhdGNoIGFmdGVyIGFsbCBhcyBpdCBubyBsb25nZXIgYnVp bGRzIGFnYWluc3QgbW9kZXJuCj4ga2VybmVscyBkdWUgdG8gdGhlIHJlZmVyZW5jZSB0byB0aGUg cmVtb3ZlZCBzbmRfc29jX2phY2tfbmV3KCkuICBJdHMKPiByZXBsYWNlbWVudCBpcyBhdCBjYXJk IGxldmVsLCBhbmQgSSBkb24ndCB0aGluayBpdCdzIGEgc2ltcGxlIGNhc2Ugb2YKPiByZXBsYWNp bmcgaXQgaGVyZS4KCkhtbS4uLiBJIHdvdWxkIHJhdGhlciB0byBmaXggaXQgaW4gbXkgc2lkZSwg YW5kIHRoZW4gSSBjb3VsZCByZWJhc2Ugb24gCnlvdXIgc2VyaWVzLCBpcyBpdCBva2F5ID8KCi0g WWFraXIKCj4+ICtzdGF0aWMgaW50IHNuZF9kd19oZG1pX2F1ZGlvX3Byb2JlKHN0cnVjdCBzbmRf c29jX2NvZGVjICpjb2RlYykKPj4gK3sKPj4gKwlzdHJ1Y3Qgc25kX2R3X2hkbWkgKmR3ID0gc25k X3NvY19jb2RlY19nZXRfZHJ2ZGF0YShjb2RlYyk7Cj4+ICsJaW50IHJldDsKPj4gKwo+PiArCXJl dCA9IHNuZF9zb2NfamFja19uZXcoY29kZWMsICJkdyBKYWNrIiwgU05EX0pBQ0tfTElORU9VVCwK Pj4gKwkJCSAgICAgICAmZHctPmphY2spOwo+IC4uLgo+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBz bmRfc29jX2NvZGVjX2RyaXZlciBkd19oZG1pX2F1ZGlvID0gewo+PiArCS5wcm9iZSA9IHNuZF9k d19oZG1pX2F1ZGlvX3Byb2JlLAo+PiArCS5kYXBtX3dpZGdldHMgPSBzbmRfZHdfaGRtaV9hdWRp b193aWRnZXRzLAo+PiArCS5udW1fZGFwbV93aWRnZXRzID0gQVJSQVlfU0laRShzbmRfZHdfaGRt aV9hdWRpb193aWRnZXRzKSwKPj4gKwkuZGFwbV9yb3V0ZXMgPSBzbmRfZHdfaGRtaV9hdWRpb19y b3V0ZXMsCj4+ICsJLm51bV9kYXBtX3JvdXRlcyA9IEFSUkFZX1NJWkUoc25kX2R3X2hkbWlfYXVk aW9fcm91dGVzKSwKPj4gK307Cj4+ICsKPj4gK3N0YXRpYyBpbnQgZHdfaGRtaV9hdWRpb19wcm9i ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+PiArewo+PiArCXN0cnVjdCBkd19oZG1p X2F1ZGlvX2RhdGEgKmRhdGEgPSBwZGV2LT5kZXYucGxhdGZvcm1fZGF0YTsKPj4gKwlzdHJ1Y3Qg c25kX2R3X2hkbWkgKmR3Owo+PiArCWludCByZXQ7Cj4+ICsKPj4gKwlkdyA9IGRldm1fa3phbGxv YygmcGRldi0+ZGV2LCBzaXplb2YoKmR3KSwgR0ZQX0tFUk5FTCk7Cj4+ICsJaWYgKCFkdykKPj4g KwkJcmV0dXJuIC1FTk9NRU07Cj4+ICsKPj4gKwlkdy0+ZGF0YSA9ICpkYXRhOwo+PiArCWR3LT5k ZXYgPSAmcGRldi0+ZGV2Owo+PiArCWR3LT5pc19qYWNrX3JlYWR5ID0gZmFsc2U7Cj4+ICsJcGxh dGZvcm1fc2V0X2RydmRhdGEocGRldiwgZHcpOwo+PiArCj4+ICsJcmV0ID0gcmVxdWVzdF9pcnEo ZHctPmRhdGEuaXJxLCBzbmRfZHdfaGRtaV9pcnEsIElSUUZfU0hBUkVELAo+PiArCQkJICBEUklW RVJfTkFNRSwgZHcpOwo+PiArCWlmIChyZXQpIHsKPj4gKwkJZGV2X2VycigmcGRldi0+ZGV2LCAi cmVxdWVzdCBpcnEgZmFpbGVkICglZClcbiIsIHJldCk7Cj4+ICsJCXJldHVybiAtRUlOVkFMOwo+ PiArCX0KPj4gKwo+PiArCXJldCA9IHNuZF9zb2NfcmVnaXN0ZXJfY29kZWMoJnBkZXYtPmRldiwg JmR3X2hkbWlfYXVkaW8sCj4+ICsJCQkJICAgICAmZHdfaGRtaV9hdWRpb19kYWksIDEpOwoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Tue, 11 Aug 2015 00:26:21 +0800 Subject: [PATCH 9/9] drm: bridge/dw_hdmi-i2s-audio: add audio driver In-Reply-To: <20150810154848.GV7557@n2100.arm.linux.org.uk> References: <20150808160936.GN7557@n2100.arm.linux.org.uk> <20150810154848.GV7557@n2100.arm.linux.org.uk> Message-ID: <55C8D0AD.3040001@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Russell, ? 2015/8/10 23:48, Russell King - ARM Linux ??: > On Sat, Aug 08, 2015 at 05:10:47PM +0100, Russell King wrote: >> From: Yakir Yang >> >> Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card >> driver could connect to this codec through the codec dai name >> "dw-hdmi-i2s-audio". >> >> [Fixed IRQ name, MODULE_DESCRIPTION, MODULE_ALIAS in >> dw-hdmi-i2s-audio.c, and platform device name in dw-hdmi.c --rmk] >> >> Signed-off-by: Yakir Yang >> Signed-off-by: Russell King > I'm dropping this patch after all as it no longer builds against modern > kernels due to the reference to the removed snd_soc_jack_new(). Its > replacement is at card level, and I don't think it's a simple case of > replacing it here. Hmm... I would rather to fix it in my side, and then I could rebase on your series, is it okay ? - Yakir >> +static int snd_dw_hdmi_audio_probe(struct snd_soc_codec *codec) >> +{ >> + struct snd_dw_hdmi *dw = snd_soc_codec_get_drvdata(codec); >> + int ret; >> + >> + ret = snd_soc_jack_new(codec, "dw Jack", SND_JACK_LINEOUT, >> + &dw->jack); > ... >> +static const struct snd_soc_codec_driver dw_hdmi_audio = { >> + .probe = snd_dw_hdmi_audio_probe, >> + .dapm_widgets = snd_dw_hdmi_audio_widgets, >> + .num_dapm_widgets = ARRAY_SIZE(snd_dw_hdmi_audio_widgets), >> + .dapm_routes = snd_dw_hdmi_audio_routes, >> + .num_dapm_routes = ARRAY_SIZE(snd_dw_hdmi_audio_routes), >> +}; >> + >> +static int dw_hdmi_audio_probe(struct platform_device *pdev) >> +{ >> + struct dw_hdmi_audio_data *data = pdev->dev.platform_data; >> + struct snd_dw_hdmi *dw; >> + int ret; >> + >> + dw = devm_kzalloc(&pdev->dev, sizeof(*dw), GFP_KERNEL); >> + if (!dw) >> + return -ENOMEM; >> + >> + dw->data = *data; >> + dw->dev = &pdev->dev; >> + dw->is_jack_ready = false; >> + platform_set_drvdata(pdev, dw); >> + >> + ret = request_irq(dw->data.irq, snd_dw_hdmi_irq, IRQF_SHARED, >> + DRIVER_NAME, dw); >> + if (ret) { >> + dev_err(&pdev->dev, "request irq failed (%d)\n", ret); >> + return -EINVAL; >> + } >> + >> + ret = snd_soc_register_codec(&pdev->dev, &dw_hdmi_audio, >> + &dw_hdmi_audio_dai, 1); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754281AbbHJQ0c (ORCPT ); Mon, 10 Aug 2015 12:26:32 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:38381 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbbHJQ0a (ORCPT ); Mon, 10 Aug 2015 12:26:30 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: jon.nettleton@gmail.com X-SENDER-IP: 220.249.180.47 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 9/9] drm: bridge/dw_hdmi-i2s-audio: add audio driver To: Russell King - ARM Linux , linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20150808160936.GN7557@n2100.arm.linux.org.uk> <20150810154848.GV7557@n2100.arm.linux.org.uk> Cc: Fabio Estevam , Takashi Iwai , Sascha Hauer , Jaroslav Kysela , David Airlie , Mark Brown , Philipp Zabel , Andy Yan , Jon Nettleton From: Yakir Yang Message-ID: <55C8D0AD.3040001@rock-chips.com> Date: Tue, 11 Aug 2015 00:26:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150810154848.GV7557@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Russell, 在 2015/8/10 23:48, Russell King - ARM Linux 写道: > On Sat, Aug 08, 2015 at 05:10:47PM +0100, Russell King wrote: >> From: Yakir Yang >> >> Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card >> driver could connect to this codec through the codec dai name >> "dw-hdmi-i2s-audio". >> >> [Fixed IRQ name, MODULE_DESCRIPTION, MODULE_ALIAS in >> dw-hdmi-i2s-audio.c, and platform device name in dw-hdmi.c --rmk] >> >> Signed-off-by: Yakir Yang >> Signed-off-by: Russell King > I'm dropping this patch after all as it no longer builds against modern > kernels due to the reference to the removed snd_soc_jack_new(). Its > replacement is at card level, and I don't think it's a simple case of > replacing it here. Hmm... I would rather to fix it in my side, and then I could rebase on your series, is it okay ? - Yakir >> +static int snd_dw_hdmi_audio_probe(struct snd_soc_codec *codec) >> +{ >> + struct snd_dw_hdmi *dw = snd_soc_codec_get_drvdata(codec); >> + int ret; >> + >> + ret = snd_soc_jack_new(codec, "dw Jack", SND_JACK_LINEOUT, >> + &dw->jack); > ... >> +static const struct snd_soc_codec_driver dw_hdmi_audio = { >> + .probe = snd_dw_hdmi_audio_probe, >> + .dapm_widgets = snd_dw_hdmi_audio_widgets, >> + .num_dapm_widgets = ARRAY_SIZE(snd_dw_hdmi_audio_widgets), >> + .dapm_routes = snd_dw_hdmi_audio_routes, >> + .num_dapm_routes = ARRAY_SIZE(snd_dw_hdmi_audio_routes), >> +}; >> + >> +static int dw_hdmi_audio_probe(struct platform_device *pdev) >> +{ >> + struct dw_hdmi_audio_data *data = pdev->dev.platform_data; >> + struct snd_dw_hdmi *dw; >> + int ret; >> + >> + dw = devm_kzalloc(&pdev->dev, sizeof(*dw), GFP_KERNEL); >> + if (!dw) >> + return -ENOMEM; >> + >> + dw->data = *data; >> + dw->dev = &pdev->dev; >> + dw->is_jack_ready = false; >> + platform_set_drvdata(pdev, dw); >> + >> + ret = request_irq(dw->data.irq, snd_dw_hdmi_irq, IRQF_SHARED, >> + DRIVER_NAME, dw); >> + if (ret) { >> + dev_err(&pdev->dev, "request irq failed (%d)\n", ret); >> + return -EINVAL; >> + } >> + >> + ret = snd_soc_register_codec(&pdev->dev, &dw_hdmi_audio, >> + &dw_hdmi_audio_dai, 1);