From: Rik van Riel <riel@redhat.com>
To: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
mingo@redhat.com, peterz@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/numa: Fix NUMA_DIRECT topology identification
Date: Mon, 10 Aug 2015 21:06:57 -0400 [thread overview]
Message-ID: <55C94AB1.30108@redhat.com> (raw)
In-Reply-To: <1439256048-3748-1-git-send-email-Aravind.Gopalakrishnan@amd.com>
On 08/10/2015 09:20 PM, Aravind Gopalakrishnan wrote:
> Systems which have all nodes at a distance of at most
> 1 hop should be identified as 'NUMA_DIRECT'.
>
> However, the scheduler incorrectly identifies it as
> 'NUMA_BACKPLANE'. This is because 'n' is assigned to
> sched_max_numa_distance but the code (mis)interprets it
> to mean 'number of hops'.
>
> Rik had actually used sched_domains_numa_levels for detecting
> a 'NUMA_DIRECT' topology-
> http://marc.info/?l=linux-kernel&m=141279712429834&w=2
>
> But that was changed when he removed the hops table in the
> subsequent version-
> http://marc.info/?l=linux-kernel&m=141353106106771&w=2
Good catch! Thank you!
> Fixing the issue here.
>
> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
next prev parent reply other threads:[~2015-08-11 1:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 1:20 [PATCH] sched/numa: Fix NUMA_DIRECT topology identification Aravind Gopalakrishnan
2015-08-11 1:06 ` Rik van Riel [this message]
2015-08-12 12:37 ` [tip:sched/core] " tip-bot for Aravind Gopalakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C94AB1.30108@redhat.com \
--to=riel@redhat.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.