From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com ([209.85.212.171]:33979 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653AbbHKHQf (ORCPT ); Tue, 11 Aug 2015 03:16:35 -0400 Received: by wicne3 with SMTP id ne3so164261556wic.1 for ; Tue, 11 Aug 2015 00:16:33 -0700 (PDT) Subject: Re: [patch added to the 3.12 stable tree] mmc: sdhci-esdhc: Make 8BIT bus work To: Joakim Tjernlund , "stable@vger.kernel.org" References: <1439216287-26416-1-git-send-email-jslaby@suse.cz> <1439216287-26416-12-git-send-email-jslaby@suse.cz> <1439220420.3120.83.camel@transmode.se> Cc: "ulf.hansson@linaro.org" , Greg KH From: Jiri Slaby Message-ID: <55C9A14F.8060609@suse.cz> Date: Tue, 11 Aug 2015 09:16:31 +0200 MIME-Version: 1.0 In-Reply-To: <1439220420.3120.83.camel@transmode.se> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 08/10/2015, 05:27 PM, Joakim Tjernlund wrote: > On Mon, 2015-08-10 at 16:17 +0200, Jiri Slaby wrote: >> From: Joakim Tjernlund >> >> This patch has been added to the 3.12 stable tree. If you have any >> objections, please let us know. > > I think 8BIT support was added after 3.12 and if so I do not think this > is appropriate for 3.12 It's in 3.12 already: $ git describe --exact-match --contains 66b50a00992d v3.11-rc1~50^2~5 But 3.10 does not need the patch. 3.10.86 was released with that though. Is it worth reverting or can it cause any havoc to the system? >> =============== >> >> commit 8e91125ff3f57f15c6568e2a6d32743b3f7815e4 upstream. >> >> Support for 8BIT bus with was added some time ago to sdhci-esdhc but >> then missed to remove the 8BIT from the reserved bit mask which made >> 8BIT non functional. >> >> Fixes: 66b50a00992d ("mmc: esdhc: Add support for 8-bit bus width and..") >> Signed-off-by: Joakim Tjernlund >> Signed-off-by: Ulf Hansson >> Signed-off-by: Jiri Slaby >> --- >> drivers/mmc/host/sdhci-esdhc.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/sdhci-esdhc.h b/drivers/mmc/host/sdhci-esdhc.h >> index a2a06420e463..ebff71092743 100644 >> --- a/drivers/mmc/host/sdhci-esdhc.h >> +++ b/drivers/mmc/host/sdhci-esdhc.h >> @@ -47,7 +47,7 @@ >> #define ESDHC_DMA_SYSCTL 0x40c >> #define ESDHC_DMA_SNOOP 0x00000040 >> >> -#define ESDHC_HOST_CONTROL_RES 0x05 >> +#define ESDHC_HOST_CONTROL_RES 0x01 >> >> static inline void esdhc_set_clock(struct sdhci_host *host, unsigned int clock, >> unsigned int host_clock) thanks, -- js suse labs