From: Juri Lelli <juri.lelli@arm.com>
To: Andrea Parri <parri.andrea@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl
Date: Tue, 11 Aug 2015 11:40:01 +0100 [thread overview]
Message-ID: <55C9D101.8020004@arm.com> (raw)
In-Reply-To: <1438782979-9057-2-git-send-email-parri.andrea@gmail.com>
Hi,
On 05/08/15 14:56, Andrea Parri wrote:
> The flag "dl_boosted" is set by comparing *absolute* deadlines
> (c.f., rt_mutex_setprio).
>
> Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
> ---
> kernel/sched/deadline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 7c17001..be2ca5e 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -953,7 +953,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
>
> /*
> * Use the scheduling parameters of the top pi-waiter
> - * task if we have one and its (relative) deadline is
> + * task if we have one and its (absolute) deadline is
> * smaller than our one... OTW we keep our runtime and
> * deadline.
> */
>
Right, thanks for spotting it.
Best,
- Juri
next prev parent reply other threads:[~2015-08-11 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 13:56 [PATCH 1/2] sched/deadline: fix comment in push_dl_tasks Andrea Parri
2015-08-05 13:56 ` [PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl Andrea Parri
2015-08-11 10:40 ` Juri Lelli [this message]
2015-08-12 12:39 ` [tip:sched/core] sched/deadline: Fix comment in enqueue_task_dl() tip-bot for Andrea Parri
2015-08-11 9:55 ` [PATCH 1/2] sched/deadline: fix comment in push_dl_tasks Juri Lelli
2015-08-12 12:39 ` [tip:sched/core] sched/deadline: Fix comment in push_dl_tasks() tip-bot for Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C9D101.8020004@arm.com \
--to=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.