From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Subject: Re: [PATCH V3] x86,
 amd_ucode: Skip microcode updates for final levels
Date: Tue, 11 Aug 2015 10:28:17 -0500
Message-ID: <55CA1491.7040502@amd.com>
References: <1438630443-1904-1-git-send-email-aravind.gopalakrishnan@amd.com>
	<55CA28720200007800099AAD@prv-mh.provo.novell.com>
	<55CA115A.1050701@amd.com> <55CA1220.8030209@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55CA1220.8030209@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: boris.ostrovsky@oracle.com, keir@xen.org, Suravee.Suthikulpanit@amd.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 8/11/2015 10:17 AM, Andrew Cooper wrote:
>>
>>>> +    0x01000098,
>>>> +    0x0100009f,
>>>> +    0x010000af
>>>> +};
>>>> +
>>>> +static bool_t check_final_patch_levels(int cpu)
>>> unsigned int
>>>
>> I can change this too, but- Any specific reason for this?
>> The other sanity checker or verification functions like
>> verify_patch_size() or microcode_fits() return a bool_t too..
> "int cpu" is the issue (I am guessing), not the return type.
>

Thought about that too.. but all the microcode_ops functions accept an 
'int cpu'.
I'm just using the same type in check_final_patch_levels().

Anyway, will wait for Jan's feedback..

Thanks,
-Aravind.