From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dyer Subject: Re: [PATCH 2/9] Input: atmel_mxt_ts - use deep sleep mode when stopped Date: Tue, 11 Aug 2015 16:55:47 +0100 Message-ID: <55CA1B03.3070605@itdev.co.uk> References: <1438615397-17112-1-git-send-email-nick.dyer@itdev.co.uk> <1438615397-17112-3-git-send-email-nick.dyer@itdev.co.uk> <55CA05A6.1020006@itdev.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from kdh-gw.itdev.co.uk ([89.21.227.133]:40057 "EHLO hermes.kdh.itdev.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965076AbbHKPzw (ORCPT ); Tue, 11 Aug 2015 11:55:52 -0400 In-Reply-To: <55CA05A6.1020006@itdev.co.uk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Benjamin Tissoires Cc: Dmitry Torokhov , linux-input , Alan Bowens On 11/08/15 15:24, Nick Dyer wrote: > On 10/08/15 21:11, Benjamin Tissoires wrote: >> I am currently running v4.2-rc6, merged with Dmitry's and Jiri's tree. >> This patch completely kills my touchpad on the Pixel 2. No touch >> information is sent while the physical button still emits values. You >> said that you tested it on this laptop too, so I wonder why mine >> refuses to work. > > I'm just building that version to see if I can reproduce. Dmitry made some > minor changes when he merged it, but I don't think it should have affected > anything. > > Are you able to send me some dmesg output with dyndbg=+pt enabled? > > It would also be useful if you could compile mxt-app and try issuing a > calibrate or reset command to see if that restores touch (let me know if > you need instructions). I've done some testing and I believe I'm able to reproduce your issue. It appears to be caused by a bad calibration, i.e. if I run the following command then the touchpad starts working: sudo ./mxt-app -d i2c-dev:0-004a --calibrate (it times out waiting for the calibration complete message when in i2c-dev mode, but that's expected) Could you verify this at your end? The patch under discussion sends a calibrate command as the input device is opened. However I can see that user space is opening/closing the device 3x in the space of about a second as X starts up, which may be confusing the firmware. It might be that we need to wait for the calibration to complete, I will try adding some code to do that.