From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org, linux-crypto@vger.kernel.org
Subject: Re: [cryptodev:master 119/123] warning: (CRYPTO_DEV_QAT_DH895xCCVF) selects PCI_IOV which has unmet direct dependencies (PCI)
Date: Tue, 11 Aug 2015 11:05:37 -0700 [thread overview]
Message-ID: <55CA3971.5070008@intel.com> (raw)
In-Reply-To: <20150811135738.GA30846@gondor.apana.org.au>
On 08/11/2015 06:57 AM, Herbert Xu wrote:
> On Mon, Aug 10, 2015 at 10:44:09AM -0700, Tadeusz Struk wrote:
>> >
>> > config CRYPTO_DEV_QAT_DH895xCCVF
>> > tristate "Support for Intel(R) DH895xCC Virtual Function"
>> > + select PCI
>> > select PCI_IOV
> Wouldn't a dependency on PCI make more sense? Or does this not
> work?
Yes, you are right. This is how it is in the PF config.
It also needs to select the qat common code.
---8<---
Fix unmet direct dependencies for QAT_DH895xCCVF
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
index 95a9566..eefccf7 100644
--- a/drivers/crypto/qat/Kconfig
+++ b/drivers/crypto/qat/Kconfig
@@ -24,7 +24,9 @@ config CRYPTO_DEV_QAT_DH895xCC
config CRYPTO_DEV_QAT_DH895xCCVF
tristate "Support for Intel(R) DH895xCC Virtual Function"
+ depends on X86 && PCI
select PCI_IOV
+ select CRYPTO_DEV_QAT
help
Support for Intel(R) DH895xcc with Intel(R) QuickAssist Technology
next prev parent reply other threads:[~2015-08-11 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201508110049.yV4f3Yls%fengguang.wu@intel.com>
2015-08-10 17:44 ` [cryptodev:master 119/123] warning: (CRYPTO_DEV_QAT_DH895xCCVF) selects PCI_IOV which has unmet direct dependencies (PCI) Tadeusz Struk
2015-08-11 13:57 ` Herbert Xu
2015-08-11 18:05 ` Tadeusz Struk [this message]
2015-08-13 7:17 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CA3971.5070008@intel.com \
--to=tadeusz.struk@intel.com \
--cc=fengguang.wu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@01.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.