Re: [PATCH 2/9] Input: atmel_mxt_ts - use deep sleep mode when stopped

[Nick Dyer <nick.dyer@itdev.co.uk>]

On 11/08/15 17:29, Benjamin Tissoires wrote:
>>> Are you able to send me some dmesg output with dyndbg=+pt enabled?
> 
> I will do that after lunch if you still need them.

Looks unnecessary given that the calibrate worked.

>> sudo ./mxt-app -d i2c-dev:0-004a --calibrate
> 
> Yep, this works with the deep sleep patches applied. On the regular
> fedora kernel (without these patches, and after a boot with the kernel
> with the patches), it does not make the touchpad back alive, however,
> a reset with the mxt-app works.
> 
> Thanks for the fast work-around.

Thanks for testing this!

>> The patch under discussion sends a calibrate command as the input device is
>> opened. However I can see that user space is opening/closing the device 3x
>> in the space of about a second as X starts up, which may be confusing the
>> firmware. It might be that we need to wait for the calibration to complete,
>> I will try adding some code to do that.
> 
> Can't you start a worker on open which will keep a ref count on how
> many open/close you make and which would do the calibration in the
> background without blocking the user-space? This way, you will be able
> to guarantee that the calibration will end, and not be re-sent if
> there are several open/close in a raw.

Yes, something like that sounds sensible.