From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com. [210.118.77.11]) by gmr-mx.google.com with ESMTPS id c1si392976pdg.0.2015.08.11.17.06.35 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 11 Aug 2015 17:06:36 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NSY00GBN0AU7P40@mailout1.w1.samsung.com> for rtc-linux@googlegroups.com; Wed, 12 Aug 2015 01:06:30 +0100 (BST) Message-id: <55CA8E05.1000704@samsung.com> Date: Wed, 12 Aug 2015 09:06:29 +0900 From: Krzysztof Kozlowski MIME-version: 1.0 To: Joonyoung Shim , rtc-linux@googlegroups.com Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, cw00.choi@samsung.com Subject: [rtc-linux] Re: [PATCH 1/4] rtc: s3c: add missing clk control References: <1439292502-22912-1-git-send-email-jy0922.shim@samsung.com> In-reply-to: <1439292502-22912-1-git-send-email-jy0922.shim@samsung.com> Content-type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 11.08.2015 20:28, Joonyoung Shim wrote: > It's missed to call clk_unprepare() about info->rtc_src_clk in > s3c_rtc_remove and to call clk_disable_unprepare about info->rtc_clk in > error routine of s3c_rtc_probe. > > Signed-off-by: Joonyoung Shim > --- > drivers/rtc/rtc-s3c.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 1/4] rtc: s3c: add missing clk control Date: Wed, 12 Aug 2015 09:06:29 +0900 Message-ID: <55CA8E05.1000704@samsung.com> References: <1439292502-22912-1-git-send-email-jy0922.shim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:15616 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932265AbbHLAGe (ORCPT ); Tue, 11 Aug 2015 20:06:34 -0400 In-reply-to: <1439292502-22912-1-git-send-email-jy0922.shim@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Joonyoung Shim , rtc-linux@googlegroups.com Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, cw00.choi@samsung.com On 11.08.2015 20:28, Joonyoung Shim wrote: > It's missed to call clk_unprepare() about info->rtc_src_clk in > s3c_rtc_remove and to call clk_disable_unprepare about info->rtc_clk in > error routine of s3c_rtc_probe. > > Signed-off-by: Joonyoung Shim > --- > drivers/rtc/rtc-s3c.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof