From: Xie XiuQi <xiexiuqi@huawei.com>
To: "Luck, Tony" <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"zhangliguang@huawei.com" <zhangliguang@huawei.com>
Subject: Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode
Date: Wed, 12 Aug 2015 10:08:31 +0800 [thread overview]
Message-ID: <55CAAA9F.70303@huawei.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F32ADCEE3@ORSMSX114.amr.corp.intel.com>
On 2015/8/12 2:52, Luck, Tony wrote:
>> Well, ok, but do it differently, please: rename
>> cmci_storm_disable_banks() to cmci_storm_switch_banks(bool on) which
>> turns them on and off. Unless Tony has a better suggestion...
>
> I like the boolean argument ... but not the "switch_banks" name. It sounds more
> like we are juggling between banks, rather than setting a switch/flag in a bank.
>
> How does "cmci_storm_set_cmci(bool on)" sound? Too many "cmci" in one name?
Thanks, I'll use this name.
--
Xie XiuQi
>
> -Tony
>
next prev parent reply other threads:[~2015-08-12 2:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 10:09 [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode Xie XiuQi
2015-08-11 14:46 ` Borislav Petkov
2015-08-11 18:52 ` Luck, Tony
2015-08-12 2:08 ` Xie XiuQi [this message]
2015-08-12 2:07 ` Xie XiuQi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CAAA9F.70303@huawei.com \
--to=xiexiuqi@huawei.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=zhangliguang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.