From: Paolo Bonzini <pbonzini@redhat.com>
To: Liang Li <liang.z.li@intel.com>, qemu-devel@nongnu.org
Cc: yang.z.zhang@intel.com, amit.shah@redhat.com,
stefanha@redhat.com, qemu-block@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] migration: do cleanup operation after completion
Date: Wed, 12 Aug 2015 11:55:44 +0200 [thread overview]
Message-ID: <55CB1820.6090603@redhat.com> (raw)
In-Reply-To: <1439413464-7326-2-git-send-email-liang.z.li@intel.com>
On 12/08/2015 23:04, Liang Li wrote:
> @@ -1008,8 +1009,10 @@ static void *migration_thread(void *opaque)
> }
>
> qemu_mutex_lock_iothread();
> + end_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
> + qemu_savevm_state_cancel();
> +
You can remove the qemu_savevm_state_cancel() call from
migrate_fd_cleanup, too. Probably best to post a v2 with that change as
well.
Paolo
next prev parent reply other threads:[~2015-08-12 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 21:04 [Qemu-devel] [PATCH 0/2] Fix long vm downtime during live migration Liang Li
2015-08-12 9:52 ` Paolo Bonzini
2015-08-12 21:04 ` [Qemu-devel] [PATCH 1/2] migration: do cleanup operation after completion Liang Li
2015-08-12 9:55 ` Paolo Bonzini [this message]
2015-08-12 11:11 ` Li, Liang Z
2015-08-12 21:04 ` [Qemu-devel] [PATCH 2/2] migration: rename qemu_savevm_state_cancel Liang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB1820.6090603@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=liang.z.li@intel.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.