From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wim Van Sebroeck" <wim@iguana.be>
Cc: kernel@pengutronix.de, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2 6/7] watchdog: mpc8xxx: use better error code when watchdog cannot be enabled
Date: Wed, 12 Aug 2015 03:21:40 -0700 [thread overview]
Message-ID: <55CB1E34.8050203@roeck-us.net> (raw)
In-Reply-To: <1439367358-5338-7-git-send-email-u.kleine-koenig@pengutronix.de>
On 08/12/2015 01:15 AM, Uwe Kleine-König wrote:
> checkpatch warns about ENOSYS, telling "ENOSYS means 'invalid syscall
> nr' and nothing else". So use ENODEV instead.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/mpc8xxx_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/mpc8xxx_wdt.c b/drivers/watchdog/mpc8xxx_wdt.c
> index 0b69797d3417..5f2273aac37d 100644
> --- a/drivers/watchdog/mpc8xxx_wdt.c
> +++ b/drivers/watchdog/mpc8xxx_wdt.c
> @@ -170,7 +170,7 @@ static int mpc8xxx_wdt_probe(struct platform_device *ofdev)
> enabled = in_be32(&ddata->base->swcrr) & SWCRR_SWEN;
> if (!enabled && wdt_type->hw_enabled) {
> pr_info("could not be enabled in software\n");
> - return -ENOSYS;
> + return -ENODEV;
> }
>
> spin_lock_init(&ddata->lock);
>
next prev parent reply other threads:[~2015-08-12 10:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 8:15 [PATCH v2 0/7] watchdog: mpc8xxx: several cleanups Uwe Kleine-König
2015-08-12 8:15 ` [PATCH v2 1/7] watchdog: mpc8xxx: remove dead code Uwe Kleine-König
2015-08-12 8:15 ` [PATCH v2 2/7] watchdog: mpc8xxx: simplify registration Uwe Kleine-König
2015-08-12 8:15 ` [PATCH v2 3/7] watchdog: mpc8xxx: make use of of_device_get_match_data Uwe Kleine-König
2015-08-12 10:16 ` Guenter Roeck
2015-08-12 8:15 ` [PATCH v2 4/7] watchdog: mpc8xxx: use devm_ioremap_resource to map memory Uwe Kleine-König
2015-08-12 10:18 ` Guenter Roeck
2015-08-12 8:15 ` [PATCH v2 5/7] watchdog: mpc8xxx: use dynamic memory for device specific data Uwe Kleine-König
2015-08-12 10:21 ` Guenter Roeck
2015-08-12 8:15 ` [PATCH v2 6/7] watchdog: mpc8xxx: use better error code when watchdog cannot be enabled Uwe Kleine-König
2015-08-12 10:21 ` Guenter Roeck [this message]
2015-08-12 8:15 ` [PATCH v2 7/7] watchdog: mpc8xxx: allow to compile for MPC512x Uwe Kleine-König
2015-08-12 10:22 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB1E34.8050203@roeck-us.net \
--to=linux@roeck-us.net \
--cc=kernel@pengutronix.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.