From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] kvm:x86:Fix error handling in the function ioapic_write_indirect Date: Wed, 12 Aug 2015 14:45:42 +0200 Message-ID: <55CB3FF6.3000407@redhat.com> References: <1439314758-23650-1-git-send-email-xerofoify@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Nicholas Krause , gleb@kernel.org Return-path: In-Reply-To: <1439314758-23650-1-git-send-email-xerofoify@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 11/08/2015 19:39, Nicholas Krause wrote: > This fixes error handling in the function ioapic_write_indirect to > properly check if the call to the function ioapoc_service service > has failed by not returning the value zero to indicate success to > check if this occurs when calling this particular function and if > so return immediately to the caller of ioapic_write_indirect due > to us no longer being able to continue the function > ioapic_write_indirect after this call fails. This is not true. You are back to the older problem that you are not trying to understand the functions you are modifying. Paolo