All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinz Mauelshagen <heinzm@redhat.com>
To: dm-devel@redhat.com
Subject: Re: [PATCH] dm-raid.txt: document discard support
Date: Wed, 12 Aug 2015 15:25:05 +0200	[thread overview]
Message-ID: <55CB4931.6050306@redhat.com> (raw)
In-Reply-To: <yq14mk9iw4d.fsf@sermon.lab.mkp.net>



On 08/08/2015 06:27 PM, Martin K. Petersen wrote:
>>>>>> "Heinz" == heinzm  <heinzm@redhat.com> writes:
> Heinz,
>
>> +Discard Support
>> +---------------
>> +The implementation of discard support amoung hardware vendors varies. When
>> +a block is discarded, some storage devices will return zeros when it is
>> +read.  These devices set the 'discard_zeros_data' attribute.  Other devices
>> +will return random data.  Confusingly, some devices will set
>> +'discard_zeros_data', but will still not always return zeros when
>> +discarded blocks are read!
> This used to be correct but that's no longer the case. We only set
> discard_zeroes_data when we have hard guarantees. We no longer
> exclusively rely on what the device reports.

Martin,

so can we rely on discard_zeroes_data if reported 100% now?

Heinz

>
> discard_zeroes_data is only set if the device reports LBPME/LBPRZ and
> uses WRITE SAME 10 or 16 (SCSI) or if it reports DRAT/RZAT and is
> explicitly whitelisted (ATA).
>

  reply	other threads:[~2015-08-12 13:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-06 14:44 [PATCH] dm-raid.txt: document discard support heinzm
2015-08-08 16:27 ` Martin K. Petersen
2015-08-12 13:25   ` Heinz Mauelshagen [this message]
2015-08-13 17:31     ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CB4931.6050306@redhat.com \
    --to=heinzm@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.