From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 1/2] x86/HVM: hvm_map_guest_frame_rw()
	adjustments
Date: Wed, 12 Aug 2015 16:44:26 +0100
Message-ID: <55CB69DA.9020904@citrix.com>
References: <55CB6FCF020000780009A2B8@prv-mh.provo.novell.com>
	<55CB7161020000780009A2D3@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=65958348f=Andrew.Cooper3@citrix.com>)
	id 1ZPYCc-0002TX-Fe
	for xen-devel@lists.xenproject.org; Wed, 12 Aug 2015 15:44:30 +0000
In-Reply-To: <55CB7161020000780009A2D3@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>, suravee.suthikulpanit@amd.com, Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>, Jun Nakajima <jun.nakajima@intel.com>, Keir Fraser <keir@xen.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On 12/08/15 15:16, Jan Beulich wrote:
> ... and its callers.
>
> While all non-nested users are made fully honor the semantics of that
> type, doing so in the nested case seemed insane (if doable at all,
> considering VMCS shadowing), and hence there the respective operations
> are simply made fail.
>
> One case not (yet) taken care of is that of a page getting transitioned
> to this type after a mapping got established.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, with one style
correction...

> @@ -4071,11 +4082,11 @@ void hvm_task_switch(
>      v->arch.hvm_vcpu.guest_cr[0] |= X86_CR0_TS;
>      hvm_update_guest_cr(v, 0);
>  
> -    if ( (taskswitch_reason == TSW_iret) ||
> -         (taskswitch_reason == TSW_jmp) )
> +    if ( (taskswitch_reason == TSW_iret ||
> +          taskswitch_reason == TSW_jmp) && otd_writable)

Space.

~Andrew